[juliusmarminge]

Stacked on #24524.

On the folded Duo, search was a button at the top of the vertical bar, next to compose. Photos puts it in a search tab that UIKit sets apart below the tab bar, which is easier to reach and keeps the top of the bar for actions.

The workspace tab bar gets a native UISearchTab (role: "search" with automaticallyActivatesSearch, which iOS 27 needs to set it apart). It never becomes selected: pressing it returns to the current list (Chats from Usage or Settings, popping an open chat) and starts its search. Search closes from the field's own cancel button.

Starting a search is list state with a focus-request counter. The header focuses the field once per request as soon as the field attaches. This replaces the effect that focused it one frame later and missed fields that mount with the request, so there is no frame waiting anywhere in the flow.

Verified on the folded Duo simulator with the software keyboard: from the Chats list, a second search after closing, from inside a chat, from Usage and from Settings; submitting a query and tapping the tab again refocuses with the query kept. Not verified: a physical Duo, and folding or unfolding while the search tab is shown.

Model: Claude Opus 5.5 | Harness: Claude Code in T3 Code

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This adds a native search tab for folded Duo devices, replacing the existing folded-Duo toolbar search control and adding cross-layer focus behavior in shared iOS navigation code. The user-facing navigation change spans several runtime layers and merits human review.

No code changes detected at 92b8326. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: t3code/duo-search-tab
• File: .coderabbit.config.ts
• Commit: 7894c99
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: bdd8508f-28b4-49b5-be8e-dcdb229d18ca

Commits

Reviewing files that changed from the base of the PR and between ea0773d and 7894c99.

Files selected for processing: 1

• apps/mobile/src/features/workspace/WorkspaceToolbar.ios.tsx

Files with no reviewable changes: 1

• apps/mobile/src/features/workspace/WorkspaceToolbar.ios.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

On folded Duo devices, iOS adds a native search tab that routes selection to search focus. The iOS toolbar removes its folded-Duo search button and related spacing and cancel-button configuration.

Changes: Folded Duo iOS search

Layer / File(s)	Summary
Native search tab and activation apps/mobile/src/features/workspace/WorkspaceNativeTabs.ios.tsx, apps/mobile/src/features/workspace/WorkspaceToolbar.ios.tsx	Adds a native search item for folded Duo devices. Search selection selects the threads tab when settings are open or the selected tab does not use columns, then schedules search focus; otherwise it dispatches search focus directly. Removes the folded-Duo toolbar search button, its spacer, and the conditional cancelButtonHidden option.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant NativeSearchItem
  participant WorkspaceNativeTabs
  participant SelectionCallback as props.onSelect
  participant HardwareSearchFocusCommand
  NativeSearchItem->>WorkspaceNativeTabs: report search selection
  alt settings are open or selected tab does not use columns
    WorkspaceNativeTabs->>SelectionCallback: select threads
    WorkspaceNativeTabs->>HardwareSearchFocusCommand: schedule search focus
  else
    WorkspaceNativeTabs->>HardwareSearchFocusCommand: dispatch search focus
  end

Loading

Possibly related PRs

• pingdotgg/t3code#24206: Both PRs change folded Duo native search behavior; #24206 addresses search focus and keyboard ownership.
• pingdotgg/t3code#23841: This PR extends the native workspace tab structure introduced by #23841 with a search slot.
• pingdotgg/t3code#18158: Both PRs change Duo search presentation while retaining the workspace search behavior.

Suggested reviewers: pixpmusic

Merge Risk: Minimal · up to 7894c

No confirmed issue blocks merging. Search activation after switching from Usage or Settings remains worth checking on a folded Duo.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description is mostly complete, but it does not follow the required template. It has no Problem, Change, Scope and approval, or Verification headings. The content covers the problem, the change, a…	Restructure the description under the template headings: Problem, Change, Scope and approval, and Verification. Under Scope and approval, link the triaged bug issue or the maintainer discussion with explicit approval of the search-tab direc…

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly describes the main change: moving folded Duo search to a search tab below the tab bar.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description is mostly complete, but it does not follow the required template. It has no Problem, Change, Scope and approval, or Verification headings. The content covers the problem, the change, and verification in prose, so it is substantive. Scope and approval is the main gap. The description says it is stacked on #24524 and gives no linked triaged issue or maintainer approval for the direction and scope of this search-tab change. Some verification detail is present (simulator checks, what was not verified), but the template asks for focused tests or checks. A before/after screenshot is included, but the template requires clear before/after images for UI changes, and the PR shows only after-state screenshots of the search tab.

Resolution

Restructure the description under the template headings: Problem, Change, Scope and approval, and Verification. Under Scope and approval, link the triaged bug issue or the maintainer discussion with explicit approval of the search-tab direction, and link the parent PR #24524 for the stacked dependency. Under Verification, list the focused checks and their observed results, keep the list of unverified items, and add before/after screenshots for the folded Duo search button versus the new search tab. Keep the model and harness line at the end.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}