Repository navigation
Conversation
External link text gets a <wbr> after every character so long URLs can wrap. In an expanded table on a wide lane the columns may shrink to their min-content width, and those break opportunities let a short link such as pingdotgg#363 collapse to "pingdotgg#36" and "3" on two lines. Hide the <wbr> inside the wide-lane table rules so the longest word sets the column width, as the table's own wrapping rules intend. Long link text still wraps through the cell's overflow-wrap. Fixes pingdotgg#24146
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Adds a narrowly scoped CSS rule that prevents character-level wrapping of external links in expanded Markdown tables while preserving existing behavior elsewhere. The change is isolated to presentation and does not affect data processing, configuration, or product defaults. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Problem
In an expanded Markdown table on a wide chat lane, a PR link chip such as
#363can break in the middle of its number, so#36and3end up on two lines. Repro: render a table whose first column holds short PR links and whose other columns hold long prose, then expand it on a lane at least 36rem wide.Change
MarkdownExternalLinkputs a<wbr>after every character of the link text so that long URLs can wrap. Those break opportunities bring the link's min-content width down to a single character. Under@container chat-lane (min-width: 36rem)(#20878), the expanded table usesmin-width: 0, so the first column can shrink to that width and the chip splits.overflow-wrap: break-wordontdis not the cause, because it doesn't change min-content.The fix is one rule inside that same container block: hide
wbrin expanded table cells. The longest word then sets the column width, which is what the table's wrapping rules intend. Long link text in a cell still wraps through the existingoverflow-wrap: break-word. Links outside tables are unchanged.apps/web/src/index.css: +6/−0.Scope and approval
Closes #24146
This is a small, focused CSS fix for a visible layout bug. It touches only the existing wide-lane expanded-table rules and adds no new behavior or settings.
Verification
Tested in the web dev app with system Chrome (headless, 1600×1000 at 2x), using a fake empty project and one seeded assistant message holding the table. No provider was called. Lane width 736px, table
data-expanded="true".main)#36/3#363I also checked a static page with a very long URL and a long unbreakable word in column 1. On a 720px lane the table still did not overflow horizontally, and the column capped at the cell's
max-width: 24rem.Before (light):

After (light):

Before (dark):

After (dark):

Checks:
vp fmt --check apps/web/src/index.css: passes.vp run --filter @t3tools/web typecheck: exit 0.vp run check:changed: passes (format, typecheck).There's no unit test because this is a CSS-only layout change, and node tests don't cover layout.
Not checked:
thcell containing a link, since onlytdwas exercised.Claude Sonnet 5.5 (xhigh) via T3 Code.