Repository navigation
perf(web): recency sorts compare timestamps directly instead of throu… - #23395
Closed
Baker-Harrison wants to merge 1 commit into
Closed
Baker-Harrison wants to merge 1 commit into
Baker-Harrison wants to merge 1 commit into
Conversation
…gh locale collation Recency sorts on PR lists, sidebar drafts and composer thread mentions compared ISO timestamps with localeCompare. Plain string comparison gives the same order without locale collation. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D8eusXBxd9KefbM96feKMs Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wf16iNrf3y8asfdkhCSn7P
github-actions
Bot
added
vouch:unvouched
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped performance refactor replacing locale-based comparisons with direct comparisons for existing ISO timestamp sorts. It affects only ordering of existing pull-request, draft, and composer results while preserving their newest-first behavior, with no product defaults or static-analysis overrides changed. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…gh locale collation
Recency sorts on PR lists, sidebar drafts and composer thread mentions compared ISO timestamps with localeCompare. Plain string comparison gives the same order without locale collation.
Claude-Session: https://claude.ai/code/session_01D8eusXBxd9KefbM96feKMs
Claude-Session: https://claude.ai/code/session_01Wf16iNrf3y8asfdkhCSn7P
Problem
Change
Scope and approval
Verification