[brandon-julio-t]

Thread Details scales sideways when opened with the right panel visible: Base UI 1.5.0 derives the origin from the wide chat header’s center, although the popup is end-aligned. This adopts Base UI’s existing fix #5015, first released in 1.8.0.

The popup now scales from its aligned edge. Centered, collision-shifted, and arrow-bearing popups retain their anchor-aware origin. The app’s animation duration and scale are unchanged.

Reproduction and motion evidence

At 1280 × 800, open a thread, open the right panel, and toggle Thread Details. The right panel’s empty launcher is enough to reproduce it. Watch the card’s right edge while it opens and closes; the settled layout is intentionally unchanged.

Before — Base UI 1.5.0, normal speed

before.mp4

After — Base UI 1.8.0, normal speed

after.mp4

Enlarged motion detail — 0.25× playback

Crops of the same recordings, slowed in playback only. The application’s timings were not changed. The host label is blurred in all recordings.

Before

before-detail.mp4

After

after-detail.mp4

Frame measurements of the same 296px popup: origin changes from 58px 0px to 296px 0px; its right edge changes from 731.24–736px during the transition to a fixed 736px. These are geometry observations, not a frame-rate benchmark.

Scope and compatibility

This uses the small, focused bug-fix exception: an existing animation defect is reproduced above and the correction already exists upstream. Related PRs #22434 and #22614 address timing and layout switching, respectively; neither fixes the origin.

This does upgrade shared UI behavior, including the web renderer used by Electron. Reviewed the cumulative 1.6–1.8 release notes and T3’s imports. The documented OTP Field rename does not apply; T3 does not import it. The lockfile updates only Base UI and its required Floating UI dependencies, preserving other consumers’ resolutions. Native React Native does not consume this package.

The PR changes only the web dependency manifest and lockfile. The current sidebar uses upstream’s controlled popover state; its release-notes lifecycle is covered by the focused browser tests below.

Verification

• vp install --frozen-lockfile passes.
• vp run check:changed passes formatting, lint, knip, and 34 affected package typechecks on the final candidate.
• vp run --filter @t3tools/web build passed during the original verification. It was not rerun for this dependency-manifest/lockfile conflict resolution.
• After merging current main, 29 focused tests across 11 files pass, covering menus/popovers, settings color and writing controls, Thread Details PR rows, update controls, and upstream’s controlled sidebar release-notes popover. See the command below. The earlier broader audit also passed 51 tests across 24 files.
• Live Chromium: Thread Details at 1280 × 800 and 390 × 844; Escape/focus return; model search and keyboard selection; permissions-select keyboard navigation; advanced-typography switch; color popover nested inside the theme dialog, including Escape returning focus without closing the parent.
• Independent Codex review found no actionable P0–P2 findings in the dependency diff. This supplements the execution evidence; it is not comprehensive application coverage.

Limits: native Electron and Safari/Firefox were not exercised. Native iOS/Android and the full repository CI suites were not run locally. The first browser-test attempt lacked Chromium; installing the required Playwright browser resolved that setup failure. These checks provide evidence for the tested paths, not a guarantee that every shared primitive is regression-free.

Focused test commands

vp test run apps/web/src/components/chat/OpenInPicker.browser.test.tsx apps/web/src/components/chat/ComposerStashMenu.browser.test.tsx apps/web/src/components/chat/AssistantCitationChip.browser.test.tsx apps/web/src/components/GitActionsControl.browser.test.tsx apps/web/src/components/settings/colorPickers.browser.test.tsx apps/web/src/components/settings/SourceControlWritingSettings.browser.test.tsx apps/web/src/components/chat/ThreadDetailsPrRow.browser.test.tsx apps/web/src/components/ServerUpdateAction.browser.test.tsx apps/web/src/components/desktopUpdate.logic.test.ts apps/web/src/components/sidebar/updateEverything.logic.test.ts apps/web/src/components/sidebar/SidebarUpdatePill.browser.test.tsx

Implemented and verified with GPT-6-Astra and GPT-6.1-Sol through the Codex harness in T3 Code; independently reviewed with GPT-6.1-Sol through Codex.

[macroscopeapp]

Approvability

Verdict: Approved at 1d6e561

Macroscope's review found this PR approvable — The PR is confined to ignored dependency metadata and lockfile paths, with no non-ignored source, schema, security, billing, deployment, product-default, or static-analysis changes. Its scope is consistent with a focused dependency-based UI bug fix.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Files ignored due to path filters: 1

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 812c0a7
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: eb0ddfed-57d1-47c3-9111-a20450591ac4

Commits

Reviewing files that changed from the base of the PR and between a07e912 and a11da55.

Files ignored due to path filters: 1

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: bfc7177
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: a54ad3c1-7192-4178-aabf-8e2bd3d60b9f

Commits

Reviewing files that changed from the base of the PR and between e74e43a and a07e912.

Files ignored due to path filters: 1

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

Files selected for processing: 1

• apps/web/package.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

The web app updates the @base-ui/react dependency range from ^1.4.1 to ^1.8.0.

Changes: Web app dependency

Layer / File(s)	Summary
Update Base UI version range apps/web/package.json	The @base-ui/react dependency range changes from ^1.4.1 to ^1.8.0.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested labels: bugfix

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · previous review a07e9

The dependency update has no identified merge-blocking risk.

Architecture risk: Low · up to 1d6e5

The change affects 1 system.

Changed systems: apps/web

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — apps/web (ui) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in apps/web/package.json: The @base-ui/react dependency constraint changed from ^1.4.1 to ^1.8.0.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main fix: anchoring popup animations to the aligned edge.
Description check		The description covers the problem, change, scope and approval rationale, verification evidence, visual motion evidence, compatibility impact, and known testing limits.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

@brandon-julio-t, your upstream fix preserves the collision-shift and arrow cases that a local CSS override would lose. i kept your implementation and commits, and merged current main (dd5b5401e1) without rebasing. the final diff is still only apps/web/package.json and pnpm-lock.yaml: base ui 1.8 and its required floating ui dependencies. nothing was dropped or added beyond the main merge.

verification at 3607a88cd8d51b9259f57ea417d209513f9aec25:

• blacksmith: frozen install, vp run check:changed (format, knip, unused-patch validation, 34 package typechecks), 44 existing tests across 19 focused files, and the production web build passed. no source files changed, so the changed-file lint stage had no applicable inputs.
• real chrome client: main reproduces a 58px origin on the 296px thread details popup; this head uses 296px. repeated toggles and escape passed at 1280×800 and 390×844, including light/dark narrow layouts. model-menu keyboard navigation/escape and settings opening passed.
• focused browser coverage includes menus, color pickers, typography, nested dialogs, sidebar release notes, toast, image dialogs, ssh prompts, provider setup and linking pull requests. two independent read-only reviews approved this exact head with no findings.
• unverified: native electron, native mobile, safari/firefox, and the full ci suites. github's CI run 40401311537 ended action_required before creating jobs; fork workflow approval is still needed. other preview workflows have the same gate. gitcafe's status is currently stale, so i checked the pushed head and actions directly on github. no labels were changed.

media note: the uploads load correctly and the video plays and seeks in chrome. gitcafe currently renders these external embeds as links; its native attachment upload returned 409 stale-operation twice after refreshing status, so inline media on gitcafe remains unavailable.

before, current main:

after, same data and layout:

opening/closing detail, main on the left and this pr on the right, normal speed:

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified as-is at 3607a88cd8d51b9259f57ea417d209513f9aec25 on a disposable linux boat vm. no source changes or pushes were needed.

• installed and ran github/main (0c80751701) in a separate worktree, then stopped its captured process group before starting the exact pr head. drove both real dev web clients with the repo's playwright and /usr/bin/google-chrome.
• added a project pointing at the real checkout through the app, selected codex gpt-6.1-sol, and sent a prompt. the main turn returned popup verification ready.. copied that app-created state for the comparison; a further turn on the pr returned pr provider path verified.. no mocks, replay provider, fixtures, or demo data were used for these runtime checks.
• at 1280×800, opened the right panel and toggled thread details three times. main reproduced the sideways motion; the pr kept the right edge fixed. these are frame geometry observations, not a performance benchmark:

                         main               pr head
popup width              296px              296px
transform origin         58px 0px           296px 0px
right edge during motion 731.24–736px        736–736px

• escape dismissed thread details and returned focus to its trigger. the model picker opened, accepted keyboard navigation, and dismissed. keyboard selection changed permissions to supervised; selecting full access restored them. a nested theme accent-color popup opened and escape retained the parent theme editor. thread details also opened and dismissed at 390×844.
• blacksmith passed vp run check:changed dd5b5401e1f240f4314af29edf431369d182f386: format, unused patches, both knip passes, and 34 package typechecks. fetching two levels of the pr's history resolved the worker's initial missing-merge-base setup failure.
• blacksmith passed 7 existing tests in ThreadDetailsPrRow.browser.test.tsx, colorPickers.browser.test.tsx, and ComposerStashMenu.browser.test.tsx.

before and after use the same conversation snapshot and viewport; the checked-out branch and its git metadata differ. inspected both full-size captures and the exported recording. uploaded images load at 1280×800; the uploaded video plays through and seeks in t3's browser.

Not verified

native electron, ios/android, windows/macos, safari/firefox, and remote/relay/tunnel connections were not exercised. the 390×844 check is the web client, not a native mobile client. other provider adapters and every other shared base ui consumer were not exhaustively exercised.

github's full ci and preview workflows remain action_required at this head, including ci run 40401311537. the remote checks above passed independently; this does not mean github ci is green.

[t3dotgg]

Note

🤖 Claude Opus 5.5 responding on behalf of Theo

Closing: this is covered by #27796, which landed. Reopen if a needed part is still missing.