Repository navigation
fix(web): use neutral indicators for inactive source control providers - #22778
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped web UI fix that changes only badge and status-dot styling for inactive or unauthenticated source-control providers. It has no apparent impact on source-control operations, data, authentication behavior, or production configuration. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update authentication and provider status presentation apps/web/src/components/settings/SourceControlSettings.tsx |
Unauthenticated status uses a secondary badge. Provider status dots use success only when available and authenticated; otherwise they use muted color. Unavailable non-provider VCS items retain the warning status. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Suggested reviewers: juliusmarminge
Merge Risk: 
Minimal · up to 1d977
-
The provider status styling change is limited to neutral indicators for inactive or unauthenticated providers.
Architecture risk: 
Low · up to 59120
-
The change affects 1 system.
Changed systems:
apps/webArchitecture concerns
No architecture-level concerns identified.Review details
-
Systems and components
- observed — apps/web (ui) was modified; 1 changed file maps to changed impact.
Before / after behavior
- observed — Modified behavior in apps/web/src/components/settings/SourceControlSettings.tsx: Changed unauthenticated authentication presentation from a warning badge to a secondary badge.
- observed — Modified behavior in apps/web/src/components/settings/SourceControlSettings.tsx: Provider items now use a success dot only when available and authenticated, and muted otherwise; the warning status branch remains for unavailable non-provider VCS items.
-
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The pull request description includes all required sections. It clearly states the problem, expected behavior, implementation change, scope rationale, verification steps, before/after screenshots, test results, limitations, and agent details.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
5912057 to
1d977bc
Compare
Problem
Source Control settings show yellow warning dots for inactive providers, including providers whose CLI or credentials have never been configured. This makes optional, inactive integrations look like problems requiring attention.
Change
Use grey dots for unavailable or unauthenticated source control providers and a neutral Not authenticated badge. Available, authenticated providers retain green dots. Version control system indicators retain their existing behavior.
The component is shared by web and desktop. Mobile does not render this provider discovery list. No contracts, provider behavior, or connection handling change.
Scope and approval
This is a small, focused presentation fix for misleading warning indicators on inactive optional integrations.
Verification
Before:

After:

vp lint apps/web/src/components/settings/SourceControlSettings.tsxpassed.vp fmt --check apps/web/src/components/settings/SourceControlSettings.tsxpassed.vp run typecheckinapps/webpassed, with existing Effect suggestions in unrelated connection files.Model: gpt-6.1-sol. Harness: Codex.