Skip to content

chore(mobile): remove the legacy v2 preview channel - #20084

Merged
juliusmarminge merged 5 commits into
mainfrom
t3/remove-v2-mobile-preview
Oct 16, 2026
Merged

juliusmarminge merged 5 commits into
mainfrom
t3/remove-v2-mobile-preview

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Problem

The legacy v2-preview profile still targets the old Play closed-testing track. APK downloads should follow the normal Alpha and internal testing tracks, with clear stability guidance.

Change

Remove the legacy EAS build/submit profiles, workflow choice, and preview-only guards. Mirror both Alpha and internal testing to the existing android-nightly release. Filenames use beta for the Alpha track and internal for internal testing, and release notes explain each track's stability and link to its APK. Keep the newest available APK per track, preserving the previous download while Play processes a replacement.

Alpha contains builds promoted for wider testing. Internal contains newer, less-tested builds. Android submissions still go to internal testing. Existing Play Console tracks and published Play artifacts are untouched.

Requested by maintainer Julius. No changes to the production/TestFlight version split.

Verification

  • Mocked both Play tracks and verified one release with both assets, first-time creation, per-track cleanup, stability notes, processing fallback, and empty tracks.
  • Node syntax, targeted lint, formatting, and diff checks pass.
  • Earlier verification covered workflow profiles and mocked mobile build reconciliation.

No cloud builds, submissions, or Play Console changes were performed.

Model: GPT-6.1 Sol. Harness: Codex through T3 Code.

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Oct 15, 2026
@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 15, 2026
@github-actions github-actions Bot added the size:M 30-99 changed lines (additions + deletions). label Oct 15, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR not approvable — The PR changes mobile release infrastructure by removing the v2-preview profile and replacing the single APK mirror with Alpha and internal-track downloads, including new asset cleanup and release-note behavior. This affects user-facing testing artifacts and scheduled distribution workflows beyond a minor configuration cleanup.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 3974b343-7edb-48cd-b708-8175a891e784
📥 Commits

Reviewing files that changed from the base of the PR and between fa1184d and a2e3779.

📒 Files selected for processing: 5
  • .github/scripts/mirror-play-apk.cjs
  • .github/workflows/mobile-android-apk.yml
  • .github/workflows/mobile-eas-production.yml
  • apps/mobile/eas.json
  • docs/operations/release.md
💤 Files with no reviewable changes: 1
  • apps/mobile/eas.json

Limit details: You’ve used all 10 included reviews currently available.

📝 Walkthrough

The Android APK mirror now targets Google Play’s internal-testing track. The v2-preview build and submit profiles, related manual-build guidance, and profile-specific workflow checks were removed. Release notes and operations documentation no longer claim nightly-server compatibility for the mirrored APK.

Changes: Android release workflow

Layer / File(s) Summary
Remove the v2-preview release path
.github/workflows/mobile-eas-production.yml, apps/mobile/eas.json
The production workflow no longer offers the v2-preview profile or runs its profile-specific checks. The matching build and submit profiles were removed.
Mirror the internal-testing APK
.github/workflows/mobile-android-apk.yml, .github/scripts/mirror-play-apk.cjs, docs/operations/release.md
The mirror workflow now selects the internal track. The workflow description, generated release notes, and operations documentation reflect the track change and remove nightly-server compatibility claims.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: sunkenintime

Merge Risk: ⚪ Minimal · up to a2e37

The remaining release profiles are configured, and the APK mirror follows the internal track used for Android production submissions. No identified issue blocks merging.

Pre-merge checks: Passed 4
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly and concisely identifies the main change: removal of the legacy mobile v2 preview channel.
Description check Passed The description includes the required Problem, Change, Scope and approval context, and Verification sections. It explains the affected profiles and workflows, identifies the maintainer request, record…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.9 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB 0 B (0.0%) 29.3 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: fa1184d · PR result: 8a8b86b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge
juliusmarminge enabled auto-merge (squash) October 16, 2026 00:07
@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Oct 16, 2026
@juliusmarminge
juliusmarminge merged commit 11b00af into main Oct 16, 2026
27 of 28 checks passed
@juliusmarminge
juliusmarminge deleted the t3/remove-v2-mobile-preview branch October 16, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant