Skip to content

refactor(mobile): organize design system and shared components - #20043

Merged
juliusmarminge merged 2 commits into
t3/mobile-ds-action-sheetsfrom
t3/mobile-ds-ui-folder
Oct 15, 2026
Merged

juliusmarminge merged 2 commits into
t3/mobile-ds-action-sheetsfrom
t3/mobile-ds-ui-folder

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

The mobile component folder mixed design-system controls with feature UI. Move the controls and their platform implementations into src/components/ui, keep cross-feature app components in src/components, and move seven feature-owned components into their owning features. Update imports and test mocks directly, without re-export shims or rendering changes.

Folder Contents
components/ui Text, symbols, buttons, rows, menus, dialogs, sheets, feedback, chrome, and their platform helpers
components Shared composer pieces, file/media previews, branding, domain icons, loading and error-boundary UI
features/threads Browser app icon, attachment button, copy button, clone banner
features/files Audio preview
features/projects Source-control icon
features/connection Permission-update notice

Validation: mobile typecheck; 25 focused tests including platform dependency graphs, header menus, Git branches, questions, and project creation; native static checks; changed-file lint and formatting. React Doctor reported no change-specific findings. No visual behavior changes, so screenshots do not apply.

Design-system progress

API adoption and Pen rendering are tracked separately. This is cumulative through this PR, not a claim that all native renderers are finished.

Pen component After this PR
Component organization Added here: components/ui, shared composites, feature-owned components
Host / native theme Colors only; native typography and shapes left
List / Section / Row Shared RN rows; native Form / ListItems left
Toggle Native switches; Android checkmark treatment left
Segmented Native + themed; custom rendering deferred
Menu Shared Menu used for Android markdown links; iOS native per-link menus retained
Sheet Shared API; Compose renderer and detent API left
Dialog Native alerts / confirm / prompt; Android actions styled; action sheets deferred
SearchField Shared API; native Android search left
Button / IconButton Android native; standalone iOS native rendering left
Chip Shared RN chip; native Android variants left
Toast Custom themed toast retained
FAB Native Android FAB; menu left
Toolbar Unified API and platform renderers
AppBar Native Android adopted; large / collapsing variants left
Picker / Slider / Stepper Native sliders on both; full Picker / Stepper family left
Progress / EmptyState Native progress + loader adoption; native iOS empty state left
Typography / shapes / motion Control tokens adopted; native Host injection left
Split / list-detail / rail Deferred broader layout work

Custom Appearance cards stay. Segmented controls stay native. Composer, thread-row and task-tray redesigns remain deferred.

Model: GPT-6.1. Harness: Codex.


Devin Review

@juliusmarminge
juliusmarminge added this pull request to stack #20030 October 15, 2026 22:01
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Oct 15, 2026
@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 15, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Oct 15, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 1c0da7b

Macroscope's review found this PR approvable — This PR reorganizes existing mobile UI and feature components without introducing new behavior; production changes are limited to equivalent import and relative-path updates. The large diff is primarily renames and caller/test updates, with no product-default or deployment changes.

No code changes detected at cdb3864. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 4.9 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.8 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.8 KiB — 29.3 KiB ✅
Codex Live turn messages — 1 — 8 ✅
Claude Total thread wire — 5.0 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.8 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 21.2 KiB — 29.3 KiB ✅
Claude Live turn messages — 1 — 8 ✅

Baseline: unavailable · PR result: cdb3864 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp
macroscopeapp Bot dismissed their stale review October 15, 2026 22:25

Dismissing prior approval to re-evaluate 1c0da7b

@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Review in Change Stack →

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge
juliusmarminge merged commit 86f4a74 into main Oct 15, 2026
30 checks passed
@juliusmarminge
juliusmarminge deleted the t3/mobile-ds-ui-folder branch October 15, 2026 22:51
vedprakash2302 added a commit to vedprakash2302/Cody that referenced this pull request Oct 16, 2026
Brings in upstream through pingdotgg#20194 (e3b35d1).

- Comment cleanup (pingdotgg#19559): most of the 38 conflicts were comments upstream removed next to Cody code. Kept Cody's code, took upstream's comment removals.
- Branding (pingdotgg#20032, Alpha to Beta): kept Cody names. A stable build shows "Cody" with no stage label, so the desktop and web checks now look for "Beta" instead of "Alpha".
- Version 0.1.0: Cody nightlies now resolve to 0.1.1-nightly.*, which sorts above 0.0.46, so installed apps still update.
- Composer model switch (pingdotgg#19869): took upstream's rewrite and kept Cody's worktree base reset in onEnvModeChange.
- Mobile scheduled task form: reapplied Cody's thread picker onto upstream's restructured screen (pingdotgg#20043).
- WSL Windows sign-in helper: unaffected by pingdotgg#19966's Windows probe change; its test now uses the new shell environment layer.
- Superseded: none. Adapted: none.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:XXL 1,000+ changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant