Repository navigation
feat(desktop): follow a local theme file independently of servers - #17883
Draft
not-compromised wants to merge 2 commits into
Draft
not-compromised wants to merge 2 commits into
not-compromised wants to merge 2 commits into
Conversation
github-actions
Bot
added
vouch:unvouched
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Desktop clients with their local environment disabled cannot follow a desktop palette independently of the server.
Change
Set
T3CODE_DESKTOP_THEME_FILEto load a T3 palette JSON file and follow atomic replacements. Missing or invalid files preserve the last valid palette. Saved preferences stay intact; a manual selection wins until the file changes or the app restarts. Linux URL launches retain the option.Scope and approval
Focused configuration of the established JSON theme capability: selecting a desktop-local source for the existing palette format and appearance controls. It is opt-in, changes no product defaults, and adds no server protocol or system-theme dependency.
Verification
Focused tests cover native file loading, IPC ordering, startup precedence, manual controls, rollback, previews, and unchanged server loading. Two startup regressions and desktop recoloring tests fail with their fixes removed. Scoped typechecks, formatting, and lint completed.
A packaged Linux AppImage followed generated dark/light palettes with its local environment disabled, retained the last valid palette after invalid input, and loaded the latest palette after reopening. Other platforms and automatic release updates were not verified.
Written by GPT-6.1 in Codex