Skip to content

fix(web): NVDA browse mode reaches the new-thread project picker again #17877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 4 commits into from
Oct 19, 2026
Merged

fix(web): NVDA browse mode reaches the new-thread project picker again #17877

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d923bab
fix(web): project picker in the composer heading is reachable in brow…
akj Oct 10, 2026
148f91c
chore: merge main into fix/composer-hero-heading-browse-mode
akj Oct 17, 2026
6d49697
Merge remote-tracking branch 'origin/main' into fix/composer-hero-hea…
juliusmarminge Oct 19, 2026
675a0d1
refactor(web): clarify the draft heading accessibility constraint
juliusmarminge Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions apps/web/src/components/chat/DraftHeroHeadline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,14 +314,6 @@ export function DraftHeroHeadline({
</button>
);

const headingLabel = isScratchDraft
? "What should we work on?"
: hasResolvedProject
? `What should we build in ${activeProjectDisplayName}?`
: canChooseProject
? `${activeProjectDisplayName ?? "Choose a project"} to start`
: "Add a project to start";

const noProjectShortcut = shortcutLabelForCommand(keybindings, "chat.newWithoutProject");
const orStartWithoutProject =
scratchWorkspaceRoot !== null && !isScratchDraft && (hasResolvedProject || canChooseProject) ? (
Expand Down Expand Up @@ -349,10 +341,8 @@ export function DraftHeroHeadline({

return (
<div className="mx-auto flex w-full max-w-5xl flex-col items-center">
<h1
aria-label={headingLabel}
className="w-full text-center font-normal text-2xl text-foreground tracking-tight sm:text-3xl"
>
{/* An explicit heading label hides the inline project picker in NVDA browse mode. */}
<h1 className="w-full text-center font-normal text-2xl text-foreground tracking-tight sm:text-3xl">
{isScratchDraft ? (
<>What should we work on?</>
) : hasResolvedProject ? (
Expand Down
Loading