Repository navigation
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused settings-search bug fix that consolidates Cmd/Ctrl+F handling into the existing sidebar search and removes a duplicate keybindings handler. The change is limited to two web components and preserves dialog, popup, composition, and shortcut-recording focus protections. You can add or adjust custom eligibility rules. Learn more. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cmd+F did not focus Settings search. Most sections fell through to the browser's Find command, while Keybindings focused its separate filter.
Change
Handle Cmd+F and Ctrl+F in the shared Settings sidebar, opening it when collapsed and focusing/selecting the search query. Remove the competing Keybindings handler so every section uses the same search. Preserve
/search, dialog focus traps, and shortcut recording.Scope and approval
This is a small, focused fix for the standard Find shortcut on the existing Settings search. It changes two web components shared by web and desktop, with no server, provider, contract, or native mobile changes.
Verification
vp test run apps/web/src/components/settings/KeybindingsSettings.environment.test.tsx apps/web/src/components/settings/settingsSearch.test.ts: 64 tests passed.vp run typecheck: passed.react/set-state-in-effectwarning in SettingsSidebarNav.Built with GPT-6.1 Sol through the Codex harness.