Repository navigation
Conversation
… size The collapsed editor used a fixed 6pt vertical inset tuned for the default 16pt text. iOS puts a line's spare height above the glyphs, so the letters moved inside the 36pt box as the text size changed. Start from the default inset and shift it by how far the lowercase midline moved.
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped iOS alignment fix that preserves the default 16pt layout and leaves expanded and Android composer behavior unchanged. Its small, isolated calculation has no broader product, schema, infrastructure, security, billing, or static-analysis impact. Notes:
You can add or adjust custom eligibility rules. Learn more. |
macroscopeapp
Bot
dismissed
their stale review
October 11, 2026 06:27
Dismissing prior approval to re-evaluate 21776af
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On iOS, the collapsed composer's text is not vertically aligned with its pill when Settings > Appearance > Text size is not the default. At 22pt the text hangs low, and at 11pt it rides high. The
+, mic and send icons stay centered, so the text looks misplaced next to them.Change
The collapsed editor is a fixed 36pt box with a fixed 6pt vertical inset, tuned for the default 16pt text. The text size setting scales the font and its line height, and iOS puts a line's spare height above the glyphs. So the letters move inside the box as the size changes, while the inset stayed at 6.
The inset now starts from the default 6pt and shifts by how far the lowercase midline moved at the current size, using DM Sans's descender and x-height. At the default size the shift is zero, so the default layout is unchanged. Android is untouched, since it already centers the single line natively.
Scope and approval
A very small, focused fix for an obvious visual bug: one helper and one prop in
ThreadComposer.tsx, with no change at the default text size.Verification
vp fmt --checkon the file andvp run --filter @t3tools/mobile typecheckpass.vp linton the file shows the same 7 warnings asmain.#if compiler(>=6.4)block inT3LayoutMetricsView.swiftcompiled out locally. That is not part of this PR.Before / after at 22pt:
Before:
After:
All three sizes. The dashed line is the pill's vertical center:
Built with Claude Opus 5.5 through Claude Code, running in T3 Code.