fix(server): missing project folders no longer log favicon warnings

[yordis]

Problem

When a project's checkout folder is moved or deleted, favicon resolution fails with a WorkspaceRootNotExistsError, and the server logs a warning for it on every enrichment pass. That failure is expected for a missing folder and is not something a maintainer or user needs to see repeated in the logs.

Change

Tag favicon resolution failures that are caused specifically by a missing workspace root, and skip the warning log for that case in ProjectEnrichmentService. Other favicon failures still log as before.

Scope and approval

Very small, focused fix for an obvious bug: a missing project folder is an expected state, yet it produces a server warning on every enrichment pass. The change only stops logging that one error case. Favicon resolution, caching, and every other failure's logging are unchanged.

Verification

Before the fix, a new focused test (does not warn about favicons for workspace roots that no longer exist in ProjectEnrichmentService.test.ts) fails: it observes a warning for both a missing-folder workspace root and a genuinely broken one, when only the broken one should warn.

After the fix, the same test passes, and the warning count is confined to the genuinely broken workspace root.

Commands run:

• vp test run src/project/ProjectEnrichmentService.test.ts src/project/ProjectFaviconResolver.test.ts (35 tests passed)
• vp run typecheck (scoped to apps/server; no errors, no new suggestions on the touched files)
• vp lint on the three changed files (clean)

Not checked: no manual run of the dev server or browser verification was done, since this is a server-side logging behavior covered directly by the added unit test.

[macroscopeapp]

Approvability

Verdict: Approved at b48befb

Macroscope's review found this PR approvable — This is a narrowly scoped server-side bug fix that suppresses warnings only for deleted or moved workspace roots while preserving logging for other favicon failures. A focused regression test verifies both behaviors, with no product-default or static-analysis configuration changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0b7f130a-e37b-4998-b06c-a6e3a5ad95be

📥 Commits

Reviewing files that changed from the base of the PR and between a183091 and b48befb.

📒 Files selected for processing (3)

• apps/server/src/project/ProjectEnrichmentService.test.ts
• apps/server/src/project/ProjectEnrichmentService.ts
• apps/server/src/project/ProjectFaviconResolver.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

Favicon enrichment now skips warning logs for resolution failures caused by nonexistent workspace roots. Other favicon failures continue to produce warnings.

Changes

Favicon failure logging

Layer / File(s)	Summary
Missing workspace root classification apps/server/src/project/ProjectFaviconResolver.ts	Adds isMissingWorkspaceRoot to identify workspace-normalization errors caused by a nonexistent workspace root.
Favicon warning handling apps/server/src/project/ProjectEnrichmentService.ts, apps/server/src/project/ProjectEnrichmentService.test.ts	The service skips logging missing-workspace-root errors. The test checks that this error does not produce a warning and that another favicon failure does.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to b48be

Missing workspace roots no longer produce favicon warnings, while other favicon failures remain visible. No merge-blocking issue was identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: missing project folders no longer produce favicon warnings.
Description check	✅ Passed	The description covers the problem, change, scope and approval rationale, and focused verification results. It also states what was not checked.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Approvability	✅ Passed	PASS. The PR changes only favicon warning handling and adds a focused test in three server source/test files. The diff adds no product default, static-analysis suppression, subsystem or workflow, cont…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}