fix(codex): retry child model lookup after empty rollout

[niko-itswld]

Fixes #15250

Problem

A Codex child can appear as "Not reported" in Lineage after its initial model lookup fails with -32603 because the rollout is still empty. The one-shot failure is swallowed, so later child metadata never reaches T3. The affected session recorded gpt-6-luna in Codex while T3 retained model: null.

Change

Lookup outcome	Behavior
Empty-rollout error	Retry up to twice, 250 ms apart, with the existing five-second timeout per request
Newer settings or reroute metadata arrives	Stop retrying and preserve the reported child model
Child is interrupted, failed, or cancelled	Stop retrying
Other error or exhausted retries	Keep the model unknown and log the error tag/code without session contents

The existing thread/resume request and child-model update path remain in place. Regression tests use the real adapter with controlled protocol responses and the Effect test clock.

Docstrings describe the adapter factory and the replay child-metadata helper.

Scope and approval

The failure and expected recovery are established in the triage comment on #15250. This is a small, focused fix for the captured startup error in one Codex adapter path.

This is low-hanging fruit for a quick review and merge: bounded recovery in an existing path, with focused regression coverage. Maintainers decide the final fix direction and merge timing.

It leaves the metadata-source changes proposed in PR #14108 separate. Missing reasoning-effort labels remain tracked by #15214.

Verification

On commit 03c92e7a:

• Before the fix, the recovery regression failed because the adapter made only one request instead of recovering on a second read. The persistent-error test also showed the missing retry path.
• vp test run apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts: all 128 tests pass. Coverage includes recovery, a three-request cap, unrelated errors, interruption, and newer settings/reroute metadata winning over stale or failed lookups.
• vp run --filter t3 typecheck: passes.
• Targeted vp lint on the three changed files: passes with two existing unused-variable warnings in the adapter.
• git diff --check: passes.

This is server-side metadata recovery, with no frontend or shared-contract edits. The captured live failure is in the issue. The fix was verified through the adapter replay harness; a new live desktop session was not run. Recovery remains bounded, so a rollout that stays empty beyond the retry window still remains unknown and produces a warning.

Model: GPT-6.1 Sol, high reasoning effort. Harness: Codex in T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at 03c92e7

Macroscope's review found this PR approvable — This is a localized server-side bug fix that adds narrowly matched, bounded retries to an existing child-model metadata lookup, with regression coverage for recovery and failure limits. Other changed files are test harness or documentation updates, and no product defaults or static-analysis suppressions are changed.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: ea136aba-8fcb-4e93-9885-548c9be1eced

📥 Commits

Reviewing files that changed from the base of the PR and between 19a9705 and 03c92e7.

📒 Files selected for processing (2)

• apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.testkit.ts
• apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The Codex adapter now retries selected empty-rollout errors during missing child-model lookups. It skips lookups when model metadata is known or the child task is interrupted, failed, or cancelled. Replay tests cover retry limits, unrelated errors, metadata races, and interruption.

Changes

Subagent model lookup

Layer / File(s)	Summary
Guarded retry and metadata handling apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts, apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.testkit.ts, apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts	The adapter skips lookup when the model is known or the task is terminal. It retries matching empty-rollout errors up to two times, 250 ms apart, and logs remaining errors. The replay callback now types its request error. Tests cover retries, race cases, and interruption.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 03c92

The bounded retry handles the modeled empty-rollout failure; no actionable merge-blocking risk remains in the reviewed changes.

Architecture Summary

Architecture risk: 🔵 Low · up to 03c92

The change affects 1 system.

Changed systems: apps/server

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — apps/server (service) was modified; 3 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts: Adds the CodexErrors import used by the child-metadata lookup test cases.
• observed — Modified behavior in apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts: Narrows the replay harness’s optional child-metadata callback error type from unrestricted unknown to CodexAppServerRequestError.
• observed — Modified behavior in apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts: Adds child model lookup tests for transient empty-rollout errors, persistent empty-rollout failures, and unrelated errors. The cases assert recovery after one failure, a three-attempt limit for persistent failures, and no retry for unrelated errors; they also verify the reported model and that retries do not continue afterward.
• observed — Modified behavior in apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts: Expands the metadata-race cases to cover both thread/settings/updated and model/rerouted, with each tested against stale and failed older lookups.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	Issue #15250 asks T3 to show the child model when metadata becomes available and not leave it permanently unknown after a temporary lookup failure. CodexAdapterV2.ts retries the matching empty-rollo…	Add a later metadata re-read trigger or equivalent recovery path so the child model can update if metadata becomes available after the initial retry window. Preserve the behavior that unknown child settings do not inherit the parent model.
Description check	⚠️ Warning	The description covers the problem, change, and focused verification. However, the scope section references a triage comment but does not state or identify explicit maintainer approval of the fix dire…	Add a direct link to and identify the maintainer comment that explicitly approves the fix direction and scope.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Out of Scope Changes check	✅ Passed	The whole-PR diff changes the Codex V2 adapter, its replay test helper, and focused adapter tests. The retry implementation, typed test callback, regression tests, and docstrings all support the #1525…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files.
Title check	✅ Passed	The title clearly and concisely identifies the main change: retrying Codex child model lookup after an empty-rollout error.

Full details: Linked Issues check

Explanation

Issue #15250 asks T3 to show the child model when metadata becomes available and not leave it permanently unknown after a temporary lookup failure. CodexAdapterV2.ts retries the matching empty-rollout error twice, and tests cover recovery, metadata precedence, interruption, and retry limits. The adapter then stops after three failed requests. The persistent-error test confirms that it makes no later lookup, so metadata that becomes available after that window still leaves the model unknown. The adapter does not fall back to the parent model.

Full details: Description check

Explanation

The description covers the problem, change, and focused verification. However, the scope section references a triage comment but does not state or identify explicit maintainer approval of the fix direction and scope.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

Dismissing prior approval to re-evaluate 03c92e7