Repository navigation
fix(mobile): follow the Android composer caret while typing - #14977
Closed
egefeyzioglu wants to merge 2 commits into
Closed
egefeyzioglu wants to merge 2 commits into
egefeyzioglu wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Android, once the chat composer reaches its max height it stops following the caret. Typing a long prompt leaves the current line out of view, and the user has to scroll the input by hand. Reported in #12690 on Samsung One UI devices and with physical keyboards.
Fix
The native editor now scrolls its own content so the caret line stays inside the viewport.
SelectionAwareEditTextcomputes the caret line from the text layout and adjustsscrollYwhen that line falls outside the padded viewport. It runs after text changes, selection changes, layout changes, controlledsetSelectioncalls from JS, and when scrolling is enabled.scrollTois a no-op while the composer is collapsed so the pill never jumps.Fixes #12690
Evidence
I could not reproduce the bug on a Pixel 7 API 36 emulator with Gboard. Stock
EditTextalready follows the caret there, on upstream main. The reports are from Samsung One UI and physical keyboards, so this still needs a check on a real device before merging.Done with Claude Fable 5.1 via Claude Code.
🤖 Generated with Claude Code