fix(models): default Claude Sonnet 5.5 to its shipped medium effort - #14193
zachweyland wants to merge 3 commits into
Conversation
pingdotgg#14152 pointed claude-sonnet-5-5 at the sonnet-5 profile, which defaults effort to high. Claude Code 2.1.284 ships default_effort "medium" for claude-sonnet-5-5 (it stays "high" for claude-sonnet-5 and claude-sonnet-4-6), so selecting Sonnet 5.5 runs hotter than the model's own default. Add a dedicated sonnet-5-5 profile, identical to sonnet-5 except for the medium effort default, and bump updatedAt. Changes made by Qwen3.8 Flash Next in OpenCode, running in T3 Code.
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This manifest change alters the shipped default Claude Sonnet 5.5 effort from high to medium, affecting how new selections are dispatched to Claude. The change is focused and otherwise low-scope, but product-default changes require human review. You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe provider model manifest adds a Sonnet 5.5 profile with effort and context-window options. The Claude Sonnet 5.5 model entry now uses this profile. ChangesSonnet 5.5 profile
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Sonnet 5.5 profile has the reported medium effort default and context-window choices. No actionable merge-blocking risk is identified; proceed with normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…onnet-5-5-default-effort # Conflicts: # apps/server/src/provider/model-manifest.json
|
Note This comment is posted by Julius' dot Please attach the Claude Code 2.1.284 catalog excerpt or probe that establishes medium as Sonnet 5.5's default, and show the resulting T3 selection. #14152 describes high as the upstream default, while this PR and #14148 report medium. Resolving that discrepancy will establish whether this is a correction under the problem and scope rule. |
…t-effort # Conflicts: # apps/server/src/provider/model-manifest.json
|
You asked for three things: the catalog value, what T3 actually selects, and why #14152 said high. Here they are. Reproduce the catalog excerptThe value lives in the installed binary's model table. On the version T3 gates Sonnet 5.5 behind ( claude --version # 2.1.284 (Claude Code)
sha256sum ~/.local/share/claude/versions/2.1.284
# 5cd90aabd83f8a15136c35aa37bb1d92b348993573316643dc3fe4e04afbf88f
rg -ao '\{id:"claude-sonnet-5-5".{0,900}?\},\{id' ~/.local/share/claude/versions/2.1.284The entry (byte offset 198719101) ends with: Not a stale-build artifact. Current stable Why #14152 said high, and why that is only true of Sonnet 5Same binary, the resolver for a model's default effort: function ge(e){return Xa(Ue(e))?.default_effort??"high"}Models that predate the field fall through to the hard-coded
So "Sonnet 5.5 defaults to high like Sonnet 5" was true of every Sonnet through 5, and 2.1.284 moved 5.5 down to medium to match Opus 5.5. The discrepancy is between the old model and the new one, not between sources. Why this matters for T3 specificallyT3 passes the resolved picker value to the CLI. Resulting T3 selection (live)Three throwaway threads on a running server, started without touching the effort picker, read from the
|
What Changed
Adds a dedicated
sonnet-5-5capability profile and pointsclaude-sonnet-5-5at it. The profile is a copy ofsonnet-5, the only difference being the default effort,mediuminstead ofhigh. BumpsupdatedAt. No UI changes.Why
#14152 pointed
claude-sonnet-5-5at thesonnet-5profile, so the picker defaults Sonnet 5.5 to High effort. That high default matches Sonnet 5 and Sonnet 4.6, but Claude Code 2.1.284's bundled model table shipsdefault_effort: "medium"forclaude-sonnet-5-5, same as Opus 5.5:default_effortin 2.1.284claude-sonnet-4-6claude-sonnet-5claude-sonnet-5-5claude-opus-5-5T3 passes
--effortexplicitly for manifest models, so selecting Sonnet 5.5 runs at a higher effort than the model's own default. #14148 independently found the same default and added the equivalent profile, but closed as a duplicate of #14152 before that difference could land.Tests:
ModelManifest.test.ts,ClaudeModelCatalog.test.ts, andClaudeAdapter.test.tspass, andvp fmt --checkis clean.Checklist
Changes made by Qwen3.8 Flash Next in OpenCode, running in T3 Code.