Repository navigation
Conversation
…cons Motivation: The icon used for the azure-devops source control kind was the Azure cloud logo, not the Azure DevOps mark. It shows on the View PR action and everywhere else the shared icon is used. Cosmetic only; linking and opening pull requests are unaffected. Approach: Replace the SVG with the single-path Azure DevOps mark (viewBox 0 0 24 24, #0078D7) in both the web AzureDevOpsIcon and the mobile SourceControlIcon "azure-devops" case. The azure-devops wiring is unchanged. This also drops the now-unneeded gradient definitions. Validation: I rendered the SVG path locally and confirmed it draws the Azure DevOps mark. I could not run lint, format, or typecheck because dependencies are not installed in this environment, and I did not launch the web or mobile client. The change is static SVG markup, so no unit test was added. Report: pingdotgg#14067 Signed-off-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com> Assisted-by: claude-sonnet-5-5 (via Claude Code)
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The PR replaces an incorrect Azure cloud icon with the Azure DevOps mark in the existing web and mobile icon components. Its runtime effect is limited to the visual glyph across existing UI surfaces, with no changes to workflows, data, configuration, or APIs. You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe mobile and web Azure DevOps icons now use a 24×24 viewBox and a single solid-blue path instead of gradient-based artwork. ChangesAzure DevOps icon
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix · Severity of issue fixed: Low Suggested reviewers: Merge Risk: ⚪ Minimal · up to The icon change fits the existing display sizes and presents no identified merge risk. Exact rasterized visual fidelity was not independently checked. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Closing: this changes UI and I can't attach the before/after screenshots the contributing guide requires for UI changes. |
What Changed
Replaced the SVG behind the Azure DevOps source control icon with the Azure DevOps mark, in both
AzureDevOpsIcon(web) and theazure-devopscase ofSourceControlIcon(mobile).Why
The icon was the Azure cloud logo rather than the Azure DevOps mark, so the View PR button, settings, command palette and other places showed the wrong glyph. The host detection and wiring were already correct, so only the asset changes. It's one shared asset, so both clients are updated.
I only rendered the SVG to check it. I did not run lint or typecheck (dependencies weren't installed here) and did not launch a client.
UI Changes
Icon glyph only; the mark is the standard Azure DevOps logo. No before/after screenshots included.
Checklist
Fixes #14067
Summary by CodeRabbit