Skip to content

fix(web): use the Azure DevOps mark for Azure DevOps source control icons - #14147

Closed
pujitha24 wants to merge 1 commit into
pingdotgg:mainfrom
pujitha24:auto/issue-14067
Closed

pujitha24 wants to merge 1 commit into
pingdotgg:mainfrom
pujitha24:auto/issue-14067

Conversation

@pujitha24

@pujitha24 pujitha24 commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

What Changed

Replaced the SVG behind the Azure DevOps source control icon with the Azure DevOps mark, in both AzureDevOpsIcon (web) and the azure-devops case of SourceControlIcon (mobile).

Why

The icon was the Azure cloud logo rather than the Azure DevOps mark, so the View PR button, settings, command palette and other places showed the wrong glyph. The host detection and wiring were already correct, so only the asset changes. It's one shared asset, so both clients are updated.

I only rendered the SVG to check it. I did not run lint or typecheck (dependencies weren't installed here) and did not launch a client.

UI Changes

Icon glyph only; the mark is the standard Azure DevOps logo. No before/after screenshots included.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Fixes #14067

Summary by CodeRabbit

  • Style
    • Updated the Azure DevOps icon in mobile and web to a solid-blue design. Its displayed size remains adjustable.

…cons

Motivation: The icon used for the azure-devops source control kind was the
Azure cloud logo, not the Azure DevOps mark. It shows on the View PR action
and everywhere else the shared icon is used. Cosmetic only; linking and
opening pull requests are unaffected.

Approach: Replace the SVG with the single-path Azure DevOps mark (viewBox
0 0 24 24, #0078D7) in both the web AzureDevOpsIcon and the mobile
SourceControlIcon "azure-devops" case. The azure-devops wiring is unchanged.
This also drops the now-unneeded gradient definitions.

Validation: I rendered the SVG path locally and confirmed it draws the Azure
DevOps mark. I could not run lint, format, or typecheck because dependencies
are not installed in this environment, and I did not launch the web or mobile
client. The change is static SVG markup, so no unit test was added.

Report: pingdotgg#14067

Signed-off-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com>
Assisted-by: claude-sonnet-5-5 (via Claude Code)
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 28, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at bc04d52

Macroscope's review found this PR approvable — The PR replaces an incorrect Azure cloud icon with the Azure DevOps mark in the existing web and mobile icon components. Its runtime effect is limited to the visual glyph across existing UI surfaces, with no changes to workflows, data, configuration, or APIs.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 721e88f4-b185-4ee5-a9cc-533e88c50552

📥 Commits

Reviewing files that changed from the base of the PR and between ed57bed and bc04d52.

📒 Files selected for processing (2)
  • apps/mobile/src/components/SourceControlIcon.tsx
  • apps/web/src/components/Icons.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The mobile and web Azure DevOps icons now use a 24×24 viewBox and a single solid-blue path instead of gradient-based artwork.

Changes

Azure DevOps icon

Layer / File(s) Summary
Azure DevOps icon rendering
apps/mobile/src/components/SourceControlIcon.tsx, apps/web/src/components/Icons.tsx
Both components replace the 96×96 gradient-based SVG artwork with a 24×24 SVG containing one solid-blue path.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge, maria-rcks

Merge Risk: ⚪ Minimal · up to bc04d

The icon change fits the existing display sizes and presents no identified merge risk. Exact rasterized visual fidelity was not independently checked.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately identifies the Azure DevOps icon correction. It does not mention the mobile client, but it clearly describes the primary change.
Description check ✅ Passed The description includes the required What Changed, Why, UI Changes, and Checklist sections. It explains the scope and validation status clearly. Screenshots are not included, but the omission is expl…
Linked Issues check ✅ Passed Issue #14067 requires the Azure DevOps mark instead of the Azure cloud icon. The PR replaces the SVG in apps/web/src/components/Icons.tsx and the azure-devops case in `apps/mobile/src/components/S…
Out of Scope Changes check ✅ Passed The changes are limited to Azure DevOps icon assets in the web and mobile source-control components. These changes directly support issue #14067. No unrelated behavior, host detection, or wiring chang…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@pujitha24

Copy link
Copy Markdown
Contributor Author

Closing: this changes UI and I can't attach the before/after screenshots the contributing guide requires for UI changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Azure DevOps PR icon is technically wrong

1 participant