Skip to content

fix(web): fast typing no longer scrambles text when type-to-focus kicks in #13708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
otavio wants to merge 1 commit into from
Closed

fix(web): fast typing no longer scrambles text when type-to-focus kicks in #13708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/web/src/components/ComposerPromptEditorTiptap.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,7 +1151,11 @@ function ComposerPromptEditorTiptapInner(props: ComposerPromptEditorProps) {
const focusAt = useCallback(
(nextCursor: number) => {
if (!editor) return;
editor.view.dom.focus({ preventScroll: true });
// view.focus() writes the state selection to the DOM as it focuses. A
// bare DOM focus leaves the native caret at the start until
// ProseMirror resyncs it 20ms later, and dictation tools type fast
// enough to land keys there, ahead of the text already inserted.
editor.view.focus();
// A newer prompt is waiting to be applied (a chip was just inserted
// through the store). Reporting the editor's stale text now would
// overwrite that prompt; the pending rewrite places the caret instead.
Expand Down
Loading