Repository navigation
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Adds settlement metadata and an opt-in settled-state filter to existing MCP thread list/read responses, with unchanged default behavior and integration coverage for settled and active cases. No product defaults, deployment behavior, or static-analysis settings are changed. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
SunkenInTime
force-pushed
the
t3code/mcp-thread-settled
branch
from
September 24, 2026 20:48
89f9846 to
b5506ab
Compare
juliusmarminge
force-pushed
the
t3code/codex-turn-mapping
branch
3 times, most recently
from
September 25, 2026 05:55
fe4f6ad to
87c67bd
Compare
Agents could not tell settled threads from active ones. List items and thread detail now carry `settled` and `settledAt`, and t3_thread_list accepts a `settled` filter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SunkenInTime
force-pushed
the
t3code/mcp-thread-settled
branch
from
September 25, 2026 13:08
b5506ab to
227a7eb
Compare
shivamhwp
merged commit Sep 27, 2026
402205e
into
pingdotgg:t3code/codex-turn-mapping
21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
t3_thread_listitems andt3_thread_read'sthreaddetail now includesettled: booleanandsettledAt: string | null.t3_thread_listaccepts an optionalsettledfilter:truereturns only settled threads,falsereturns only active ones.settledOverride === "settled", the same check the sidebar uses. Manual settles and auto-settles (PR merged, inactivity) both count.settledAtisnullwhenever the thread is not settled.4 files, about +66 lines, most of them the test.
Why
Orchestrator V2 settles threads out of the active list, but the orchestrator MCP didn't expose that state. An agent that listed or read threads couldn't tell a settled thread from an active one. Passing
settledtot3_thread_listwas silently ignored, so the agent got every thread back.The data was already on
OrchestrationV2ThreadShelland the thread projection. This change maps it through the two existing tools. There's no new tool and no change to the projection.Reproduction
t3code/codex-turn-mapping. Create a thread, let it finish, and settle it from the sidebar menu.t3_thread_list, thent3_thread_list({settled: true}), thent3_thread_readon the settled thread.settled: true, and the filter returns only that thread.Actual: neither tool returns a settled field, and
settled: truereturns all 4 threads.Verification
OrchestratorMcpToolkit.integration.test.ts. The test settles a thread and checkssettled/settledAton both tools and both filter values. It failed before the fix (missingsettled) and passes after.PONG).UI Changes
This PR doesn't change the UI. The screenshots show what the agent reports from the MCP tools.
Before: settled fields are missing and
settled: truedoesn't filter.After:
PONGreportssettled: truewith itssettledAt, andsettled: truereturns onlyPONG.Notes
Local checks on Windows that are unrelated to this diff:
vp lintfails to parsevite.config.ts(excludeFilesis unknown to the installed vp 0.3.3), so CI'svp checkcovers lint.vp fmt --checkpasses on the changed files. Typecheck reports no errors in them.reports running and queued child follow-ups from a Codex replay transcriptfails on Windows with aC:\C:\…fixture path. It fails the same way without this change.Checklist
🤖 Generated with Claude Code