refactor(web): give TooltipPopup width and code variants - #12986
juliusmarminge wants to merge 2 commits into
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityEvaluating 3ca7f7d… No code changes detected at |
|
Good catch. Fixed in 0c0c925 by putting |
0c0c925 to
8e1c7f5
Compare
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Limit details: You’ve used all 10 included reviews currently available. 📝 WalkthroughWalkthroughThe change adds shared tooltip width and code-style options. Existing tooltip instances replace local sizing and wrapping classes with these options. Dialog titles gain anywhere-wrapping support, and the restyle lint ceiling decreases. ChangesTooltip styling standardization
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~15 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to This change standardizes tooltip sizing and code styling and enables consistent dialog-title wrapping. No merge-blocking risk remains identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
8e1c7f5 to
a3d7913
Compare
c65aebb to
4204ed6
Compare
Dismissing prior approval to re-evaluate 4204ed6
4204ed6 to
3ca7f7d
Compare
Every multi-line tooltip set its own max-width and line-height through className, in eight different combinations, and every path or command tooltip re-declared the same monospace treatment. Expose width="sm..2xl" (max-w-64 through max-w-120, wrapping enabled) and variant="code" (monospace, 11px, breaks anywhere) and migrate the 60 call sites. Visible effect: wrapped tooltips now share one line-height (leading-snug) where sites previously picked tight or relaxed, and code tooltips share one size. Widths map to the nearest step of the scale. Lowers the no-restyle ceiling from 1206 to 1146. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Restores the wrap-anywhere that ConfirmDialogHost set per site, on the DialogTitle and AlertDialogTitle base instead, since every dialog title can interpolate a path or branch name. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
3ca7f7d to
c244489
Compare
|
Superseded by the reworked stack (#12993 v2). After review feedback the layers were rebuilt to add fewer props and take more opinions in the base; see the new stack for the replacement. |
Every multi-line tooltip set its own max-width and line-height through
className, in eight different combinations, and every path or command
tooltip re-declared the same monospace treatment. Expose width="sm..2xl"
(max-w-64 through max-w-120, wrapping enabled) and variant="code"
(monospace, 11px, breaks anywhere) and migrate the 60 call sites.
Visible effect: wrapped tooltips now share one line-height (leading-snug)
where sites previously picked tight or relaxed, and code tooltips share one
size. Widths map to the nearest step of the scale.
Lowers the no-restyle ceiling from 1206 to 1146.
Part of the
components/uiclassName cleanup (audit and guardrail: #12982). Each layer of stack #12993 lowers theshadcn/no-restyleceiling; CI fails if the count rises.Written by Claude Fable 5 in Claude Code.
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Style