Repository navigation
Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughChangesDictation review flow
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant VoiceInputController
participant ThreadComposer
participant ThreadDetailScreen
VoiceInputController->>ThreadComposer: update draft message
ThreadComposer->>ThreadDetailScreen: call onDictationComplete()
ThreadDetailScreen->>ThreadComposer: set review state and select review chrome
ThreadComposer->>ThreadComposer: remain expanded with minHeight 160
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Thanks for working on this. We merged the orchestrator V2 rewrite in #2829, and we are closing this PR as part of that transition. The patch conflicts with the rewrite in apps/mobile/src/features/threads/ThreadComposer.tsx, apps/mobile/src/features/threads/ThreadDetailScreen.tsx. Even where the conflict is small enough to rebase, we are asking for fresh PRs against the new base so we can review and verify the behavior in V2. Sorry for the extra work this creates. If the change is still needed on V2, please rebuild it on current main, verify it there, and open a new PR linking back here. We're closing the current implementation without assuming the underlying request is resolved. |
What Changed
After dictation finishes, expand the mobile composer into its full-height reading area without focusing the editor or opening the keyboard. Tap the text to edit, or tap the conversation to collapse it. Successful sends clear the review state.
Why
A transcript completed from the collapsed composer stayed in one line. Review should make the text readable without immediately opening the keyboard. The review state is scoped to the thread, with matching feed spacing and safe-area padding.
Scope and approval
There is no prior issue or discussion. I am submitting this under the small, focused fix exception in CONTRIBUTING.md.
If you read this as a product behavior change and not a bug fix, tell me and I will take it to an Ideas discussion first.
UI Changes
Before/after video
Verified on an iOS 26.5 simulator with temporary simulated recorder and transcript responses. Real microphone capture and speech recognition were not tested. All fixtures were removed before committing.
Validation
The new-task composer already uses an expanded editor. This change is in the existing-thread mobile UI and applies independently of provider and connection mode.
Checklist
Model: GPT-6. Harness: Codex.
Summary by CodeRabbit