Conversation
Exclude shared dialog popups from Electron window dragging. Tall theme search results place the close button over the titlebar drag region, which intercepted its center while leaving the bottom edge clickable. Verified native Electron center clicks before and after, the full browser theme flow, all 4,453 web tests, web typecheck, and targeted lint/format checks. Standards and spec reviews found no issues. Implemented with GPT-6-Astra in Codex.
github-actions
Bot
added
vouch:unvouched
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe dialog popup class now marks the popup as outside the WebKit draggable window region. All other dialog classes remain unchanged. ChangesDialog popup interaction
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The popup controls are excluded from the native drag region, preserving interaction without introducing merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Preserve the dialog no-drag fix in the shared popup base while retaining main's standard and media dialog variants.
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
2 participants
Fixes #11573
What Changed
Mark shared dialog popups with
-webkit-app-region: no-dragso their controls remain interactive when they overlap a desktop titlebar. This restores the theme import dialog's existing X hover state and center click, and covers the shared confirmation-dialog and command-palette popup styles.Why
Searching for a theme makes the modal taller and moves its close button into the desktop header's window-drag region. Electron intercepts native pointer events in that region even though the dialog renders above it. The center of the X does not hover or close the dialog; the lower edge below the drag strip remains clickable.
Reproduction:
Reproduced on macOS with native pointer input: two center clicks left the dialog open, while a lower-edge click closed it. Browser checks at 1280×900 and 1280×720 passed even before the fix, which narrowed the problem to desktop hit testing.
Verification
ThemeImportDialogandWorkspacePageHeader. With the desktop drag region still enabled, the fixed X shows its hover state and closes on a native center click.The native pointer check is the regression proof here: the existing non-browser unit suite cannot exercise Electron's window-drag hit testing. No class-string assertion was added.
UI Changes
Evidence uses an isolated reproduction with no user data. Screenshots and video are cropped to the dialog header and search controls. The video labels mark the tested click locations; pauses are trimmed.
Before: the pointer is over the X center, but the hover background does not appear.
After: the same center position shows the existing hover background.
Native interaction recording (11 seconds): center click ignored before the fix; bottom-edge click succeeds; center click succeeds after the fix.
theme-close-before-after.mp4
Checklist
Implemented with GPT-6-Astra in the Codex harness.
Summary by CodeRabbit