Skip to content

fix(mobile): keep Android adaptive icons within the safe area - #10425

Closed
ryanrhughes wants to merge 2 commits into
pingdotgg:mainfrom
ryanrhughes:fix/android-icon-crop
Closed

fix(mobile): keep Android adaptive icons within the safe area#10425
ryanrhughes wants to merge 2 commits into
pingdotgg:mainfrom
ryanrhughes:fix/android-icon-crop

Conversation

@ryanrhughes

@ryanrhughes ryanrhughes commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

What Changed

Android's adaptive mask was cutting off the T3 mark. Dev and preview used complete app artwork as their foreground, and the shared Android mark extended beyond the safe area.

Keep adaptive and monochrome icons. Center the existing T3 vector mark at 54dp wide on the 108dp canvas, with transparent padding that keeps every visible pixel inside Android's guaranteed 66dp safe circle. Give dev and preview separate full-bleed backgrounds rendered from their existing Icon Composer background SVGs. Launcher shortcuts use the same layers.

Why

The icons were being cutoff.

UI Changes

No more cutoff. 🎉
image

Still compatible with dynamic color palettes as well.
image

Note

Fix Android adaptive icons to stay within safe area using local mark and variant backgrounds

  • Updates DEVELOPMENT_ASSETS and PREVIEW_ASSETS in app.config.ts to use the local android-icon-mark.png foreground and adds variant-specific background images (android-icon-background-dev.png, android-icon-background-preview.png)
  • Configures expo-quick-actions Android shortcut icons to include the variant background image and a monochrome icon alongside the existing foreground and background color
  • Release builds explicitly omit a background image and continue using the black background color

Macroscope summarized 531aec8.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 6, 2026
@ryanrhughes ryanrhughes changed the title fix(mobile): prevent Android app icons from cropping fix(mobile): keep Android adaptive icons within the safe area Sep 7, 2026
@ryanrhughes
ryanrhughes marked this pull request as ready for review September 7, 2026 00:55
@macroscopeapp

macroscopeapp Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR changes the mobile app’s default Android launcher and shortcut artwork through Expo native build configuration and new image assets. The change is narrowly scoped, but product-default changes require human review.

Not approved because:

  • Monthly spending limit reached (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge

Copy link
Copy Markdown
Member

Superseded by #10598 (merged) — same Android adaptive-icon safe-area / variant background fix landed on main via the export-android-icons path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants