Skip to content

sqlreplay: deduplicate audit logs and ignore uninitialized statements#863

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:mainfrom
djshow832:duplicate
Sep 10, 2025
Merged

sqlreplay: deduplicate audit logs and ignore uninitialized statements#863
ti-chi-bot[bot] merged 1 commit into
pingcap:mainfrom
djshow832:duplicate

Conversation

@djshow832
Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #862

Problem Summary:

  • Audit logs record the beginning and end of each statement, but we only care about the beginning
  • Audit logs may contain existing connections, wait until the current db is specified

What is changed and how it works:

  • Move the deduplication from the replay process to the decode process to decouple logic
  • If a connection is not started with a Connected event, ignore the table accesses until a Use statement shows

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot requested review from bb7133 and xhebox September 10, 2025 01:37
@ti-chi-bot ti-chi-bot Bot added the size/L label Sep 10, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.72340% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@90d8093). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/sqlreplay/cmd/audit_log_plugin.go 78.26% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #863   +/-   ##
=======================================
  Coverage        ?   67.47%           
=======================================
  Files           ?      132           
  Lines           ?    12591           
  Branches        ?        0           
=======================================
  Hits            ?     8496           
  Misses          ?     3496           
  Partials        ?      599           
Flag Coverage Δ
unit 67.47% <78.72%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Sep 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the lgtm label Sep 10, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Sep 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-10 02:18:08.402265785 +0000 UTC m=+414154.962147282: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 10, 2025
@ti-chi-bot ti-chi-bot Bot merged commit 01ded1c into pingcap:main Sep 10, 2025
6 checks passed
@djshow832 djshow832 deleted the duplicate branch September 10, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deduplicate audit logs and ignore uninitialized statements

3 participants