Skip to content
This repository was archived by the owner on Aug 21, 2023. It is now read-only.

*: use show full tables in ListAllDatabasesTables (#325) - #331

Closed
ti-chi-bot wants to merge 1 commit into
pingcap:release-5.0from
ti-chi-bot:cherry-pick-325-to-release-5.0
Closed

*: use show full tables in ListAllDatabasesTables (#325)#331
ti-chi-bot wants to merge 1 commit into
pingcap:release-5.0from
ti-chi-bot:cherry-pick-325-to-release-5.0

Conversation

@ti-chi-bot

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #325

What problem does this PR solve?

close #322

What is changed and how it works?

when meet a specific buggy version of mysql [8.0.3 8.0.23), use SQL show full tables to get all table names from upstream database.

As the average data size per row of data is not taken from the Show full table results, dumpling will set this value to 200000.
This has the potential to cause the user to export too many or too few files, but I find this more acceptable than getting stuck in the dump stage.

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • fix pending on show table status in some mysql version

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot

Copy link
Copy Markdown
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot

Copy link
Copy Markdown
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot

Copy link
Copy Markdown
Member Author

@ti-chi-bot: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ehco1996 Ehco1996 closed this Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants