Skip to content
This repository was archived by the owner on Aug 21, 2023. It is now read-only.

export: initial work to support MemSQL/SingleStore (#311) - #327

Merged
ti-chi-bot merged 4 commits into
pingcap:release-5.0from
ti-chi-bot:cherry-pick-311-to-release-5.0
Aug 23, 2021
Merged

export: initial work to support MemSQL/SingleStore (#311)#327
ti-chi-bot merged 4 commits into
pingcap:release-5.0from
ti-chi-bot:cherry-pick-311-to-release-5.0

Conversation

@ti-chi-bot

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #311

What problem does this PR solve?

Issue: #309

  • WITH CONSISTENT SNAPSHOT is not supported by MemSQL (same for Vitess).
  • SHOW CREATE DATABASE is not supported by MemSQL.

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

  • Support for backing up MySQL compatible databases that don't support START TRANSACTION ... WITH CONSISTENT SNAPSHOT
  • Support for backing up MySQL compatible databases that don't support SHOW CREATE TABLE

Issue: pingcap#309

- `WITH CONSISTENT SNAPSHOT` is not supported by MemSQL (same for
  Vitess).
- `SHOW CREATE DATABASE` is not supported by MemSQL.
@ti-chi-bot

ti-chi-bot commented Aug 3, 2021

Copy link
Copy Markdown
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Comment thread v4/export/sql.go Outdated
Comment thread v4/export/sql.go
@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer approved (LGTM1) label Aug 23, 2021
Comment thread v4/export/sql.go Outdated

@lichunzhu lichunzhu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu

Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot

Copy link
Copy Markdown
Member Author

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1cdd198

@ti-chi-bot
ti-chi-bot merged commit ea5e15d into pingcap:release-5.0 Aug 23, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.0.4 milestone Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants