Skip to content

SPM: update DML SQL Bind and baseline capture description - #5088

Merged
ti-chi-bot merged 6 commits into
pingcap:masterfrom
CharLotteiu:dml_spm
Mar 29, 2021
Merged

SPM: update DML SQL Bind and baseline capture description#5088
ti-chi-bot merged 6 commits into
pingcap:masterfrom
CharLotteiu:dml_spm

Conversation

@CharLotteiu

@CharLotteiu CharLotteiu commented Mar 23, 2021

Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

Update SPM documentation for DML SQL Bind and baseline capture

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2021
@CharLotteiu

CharLotteiu commented Mar 23, 2021

Copy link
Copy Markdown
Contributor Author

/translation from-docs-cn
/status PTAL
/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/cc TomShawn eurekaka

@ti-chi-bot
ti-chi-bot requested review from TomShawn and eurekaka March 23, 2021 09:40
@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. status/PTAL This PR is ready for reviewing. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Mar 23, 2021
@CharLotteiu

CharLotteiu commented Mar 23, 2021

Copy link
Copy Markdown
Contributor Author

/label v5.0

@ti-chi-bot ti-chi-bot added the v5.0 This PR/issue applies to TiDB v5.0. label Mar 23, 2021
@TomShawn

TomShawn commented Mar 24, 2021

Copy link
Copy Markdown
Contributor

/uncc @TomShawn
/cc @yikeke

@ti-chi-bot
ti-chi-bot requested review from yikeke and removed request for TomShawn March 24, 2021 07:22
eurekaka
eurekaka reviewed Mar 24, 2021
View reviewed changes
Comment thread sql-plan-management.md Outdated
Comment thread sql-plan-management.md Outdated
Comment thread sql-plan-management.md Outdated
Comment thread sql-plan-management.md Outdated
Comment thread sql-plan-management.md Outdated
Comment thread sql-plan-management.md Outdated
Comment thread sql-plan-management.md Outdated
Comment thread sql-plan-management.md Outdated
@CharLotteiu @eurekaka
Apply suggestions from code review
259a965 
Co-authored-by: Kenan Yao <cauchy1992@gmail.com>
@yikeke
yikeke requested review from ran-huang and removed request for yikeke March 29, 2021 01:35
ran-huang
ran-huang reviewed Mar 29, 2021
View reviewed changes
Comment thread sql-plan-management.md
Comment thread sql-plan-management.md
Comment thread sql-plan-management.md
Comment thread sql-plan-management.md
Comment thread sql-plan-management.md
Comment thread sql-plan-management.md Outdated
Comment thread sql-plan-management.md Outdated

In addition, when you create a binding, TiDB requires that the session is in a database context, which means that a database is specified when the client is connected or `use ${database}` is executed.

> **Note:**

@ran-huang ran-huang Mar 29, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this Note format? It looks distracting to have two notes on end, and it's not marked as a note in the Chinese doc.

@CharLotteiu CharLotteiu Mar 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was suggested to be marked as a note in #1249 (comment), but I agree with you. I will update it later.

@CharLotteiu CharLotteiu Mar 29, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 5fe294d.

Comment thread sql-plan-management.md Outdated
Comment thread sql-plan-management.md Outdated
Comment thread sql-plan-management.md Outdated
CharLotteiu and others added 4 commits March 29, 2021 11:27
@eurekaka

eurekaka commented Mar 29, 2021

Copy link
Copy Markdown
Contributor

/lgtm

@ti-chi-bot

ti-chi-bot commented Mar 29, 2021

Copy link
Copy Markdown
Member

@eurekaka: /lgtm is only allowed for the reviewers in list.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ran-huang

ran-huang commented Mar 29, 2021

Copy link
Copy Markdown
Contributor

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 29, 2021
@CharLotteiu

CharLotteiu commented Mar 29, 2021

Copy link
Copy Markdown
Contributor Author

/merge

@ti-chi-bot

ti-chi-bot commented Mar 29, 2021

Copy link
Copy Markdown
Member

@CharLotteiu: /merge in this pull request requires 1 /lgtm.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ran-huang

ran-huang commented Mar 29, 2021

Copy link
Copy Markdown
Contributor

/lgtm

@ti-chi-bot

ti-chi-bot commented Mar 29, 2021

Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2021
@ran-huang

ran-huang commented Mar 29, 2021

Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot

ti-chi-bot commented Mar 29, 2021

Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5fe294d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2021
@ti-chi-bot
ti-chi-bot merged commit a355e5c into pingcap:master Mar 29, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 29, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5088 to release-4.0
0c13342 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2021
Merged
10 tasks
@ti-srebot

ti-srebot commented Mar 29, 2021

Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #5150

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 29, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5088 to release-5.0
41c38aa 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2021
Merged
10 tasks
@ti-srebot

ti-srebot commented Mar 29, 2021

Copy link
Copy Markdown
Contributor

cherry pick to release-5.0 in PR #5151

ti-chi-bot pushed a commit that referenced this pull request Mar 29, 2021
@ti-srebot
SPM: update DML SQL Bind and baseline capture description (#5088) (#5151
d4f425b 
)
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021
@ti-srebot
SPM: update DML SQL Bind and baseline capture description (#5088) (#5150
d74db0c 
)
@CharLotteiu
CharLotteiu deleted the dml_spm branch July 9, 2021 03:21
@yahonda yahonda mentioned this pull request Aug 20, 2026
Merged
14 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 24, 2026
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@eurekaka eurekaka eurekaka left review comments
@ran-huang ran-huang ran-huang left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@CharLotteiu @TomShawn @eurekaka @ti-chi-bot @ran-huang @ti-srebot