update SPM document - #2679
Merged
Merged
Conversation
TomShawn
added
translation/from-docs-cn
Contributor
|
@lzmhhh123, @yikeke, PTAL. |
Contributor
|
Please help review this PR, thanks~ @CaitinChen |
yikeke
removed their request for review
June 8, 2020 05:15
CaitinChen
reviewed
Jun 8, 2020
|
|
||
| > **Note:** | ||
| > | ||
| > Because TiDB has some embedded SQL statements to ensure the correctness of some functions, baseline capturing by default automatically shields these SQL statements. |
Contributor
There was a problem hiding this comment.
"the correctness of some functions" or "the correctness of some features"？
If we use "functions," users might confuse it with 函数.
Contributor
Author
There was a problem hiding this comment.
Changed to feature.
Co-authored-by: Caitin <34535727+CaitinChen@users.noreply.github.com>
TomShawn
commented
Jun 8, 2020
Contributor
Author
|
@CaitinChen All comments addressed, PTAL again, thanks! |
TomShawn
added
status/can-merge
Contributor
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/docs
that referenced
this pull request
Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Contributor
|
cherry pick to release-4.0 in PR #2736 |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Mention the SQL plan management in sql-binding.md。
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?