i18n(ja): fix dropped subject-marker particle before predicates - #23624
Open
yahonda wants to merge 5 commits into
Open
i18n(ja): fix dropped subject-marker particle before predicates#23624yahonda wants to merge 5 commits into
yahonda wants to merge 5 commits into
Conversation
…commit '00bce58fde' into fix-dropped-ga-particles-2026-08-27
|
Warning Review limit reachedNext included review available in 6 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (94)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ti-chi-bot
Bot
added
area/develop
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/L
6 tasks
yahonda
added a commit
that referenced
this pull request
Aug 27, 2026
55 sites across 51 files where the topic particle は appears to be missing immediately after a code span/bracket, before a definitional or state predicate (becomes/is called/represents/corresponds to/is supported/etc.). NOT individually verified against the English source per-site, unlike the previous を (#23579/#23611) and が (#23624) sweeps. は is far more context-dependent than を/が (Japanese frequently and correctly omits は when a topic is already established), so a mechanical detector has a much higher false-positive rate here. Submitted as a draft specifically so a human can review each site before merging. UPDATE: user review caught a systemic false-positive class in the になります/となります predicate category (18 sites) -- the captured code span/bracket is the COMPLEMENT (the resulting value) of the "becomes X" predicate, not its subject, e.g. "この機能が一般提供 （GA）となります" (the feature becomes GA) mis-edited to insert は right before となります, producing the ungrammatical "一般提供（GA） はとなります". All 18 sites in this predicate category were reverted; 37 sites across the other predicate categories remain.
yahonda
added a commit
that referenced
this pull request
Aug 27, 2026
Started at 55 sites/51 files. Two systemic false-positive classes were found and fully reverted through iterative user review: 1. になります/となります predicates (18 sites): the captured code span/bracket is the COMPLEMENT of the "becomes X" predicate, not its subject -- e.g. "この機能が一般提供（GA）となります" was mis-edited to "一般提供（GA）はとなります", which is ungrammatical since GA is what the feature becomes, not a new topic. 2. と呼ばれる/と呼ばれます, を表す/を表します/を意味します/を指す, に相当します/に相当する predicates (24 sites): same complement-vs- subject issue for "is called X" patterns, plus a related structural flaw -- predicates already starting with a particle (を.../に...) mean the code span is already correctly particle-marked as that verb's argument, so inserting は immediately before an existing を/に is always wrong (produces stacked-particle nonsense like 「Xはを指す」). Also reverted 2 sites (dm/dm-error-handling.md, tidb-cloud/sql- concepts.md) that turned out to sit inside a pre-existing, unrelated MT-scramble defect where a particle insertion alone cannot produce a grammatical sentence -- these had already been independently flagged and skipped for the same reason during the earlier が sweep (#23624). 11 sites across 11 files remain, from predicate categories that held up under review (有効です/可能です/サポートされていません/必要です/ デフォルトで/利用できません/含まれます) -- these are still NOT individually re-verified against the English source, so continue to treat this as a draft.
yahonda
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Continuation of the comprehensive dropped-particle review (following #23579 and #23611, which covered を drops before common action verbs). This PR covers the が particle — dropped immediately after a code span/bracket, before a state-describing or passive predicate (e.g. 有効です, 必要です, 設定されます, 削除されます, 無視されます).
Example: EN "If set,
--fromand--towill be ignored." was translated as "設定されている場合、--fromと--to無視されます。" (missing が) instead of the correct "--fromと--toが無視されます。"Method: a regex scan for code-span/bracket immediately followed by ~70 common state/passive predicates found 126 unique candidates corpus-wide. Each candidate was individually verified against the English source (4-way parallel review) — 113 confirmed genuine drops and fixed, 13 correctly skipped as false positives (wrong particle direction needing に/と instead, subject already marked elsewhere in the sentence, or a pre-existing unrelated scramble needing a different fix).
94 files changed.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?