i18n(ja): fix plain-form sentences stranded in polite prose - #23584
Open
yahonda wants to merge 1 commit into
Open
i18n(ja): fix plain-form sentences stranded in polite prose#23584yahonda wants to merge 1 commit into
yahonda wants to merge 1 commit into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe pull request updates Japanese documentation across TiDB guides and reference pages. Most changes standardize polite sentence endings, grammar, and punctuation. Troubleshooting and release-note descriptions also receive wording and factual corrections. ChangesDocumentation wording alignment
Estimated code review effort: 2 (Simple) | ~15 minutes Merge Risk: 🟠 High · up to This PR changes Japanese documentation wording and formatting across 110 files, but several edits could still mislead users about supported SQL, compliance scope, execution behavior, version applicability, or troubleshooting procedures that may leave garbage collection disabled. These concrete correctness and operational risks should be fixed before merging; the remaining formatting issues are minor. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
|
|
ti-chi-bot
Bot
added
size/M
yahonda
marked this pull request as draft
August 20, 2026 08:29
ti-chi-bot
Bot
added
do-not-merge/work-in-progress
yahonda
changed the title
yahonda
marked this pull request as ready for review
August 24, 2026 01:02
ti-chi-bot
Bot
removed
the
do-not-merge/work-in-progress
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 12
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 68232524-0be5-4483-b712-2753ccac0e1e
📒 Files selected for processing (110)
ai/concepts/vector-search-overview.mdai/integrations/tidb-mcp-server.mdai/quickstart-via-python.mdalert-rules.mdas-of-timestamp.mdbackup-and-restore-using-dumpling-lightning.mdbest-practices/_index.mdbest-practices/tidb-best-practices.mdbr/backup-and-restore-overview.mdcheck-before-deployment.mdclinic/clinic-data-instruction-for-tiup.mdconfigure-load-base-split.mddashboard/dashboard-profiling.mddashboard/top-sql.mddevelop/dev-guide-connection-parameters.mddevelop/dev-guide-sample-application-golang-sql-driver.mddevelop/dev-guide-sample-application-java-jdbc.mddevelop/dev-guide-sample-application-python-django.mddevelop/dev-guide-sample-application-python-mysql-connector.mddevelop/dev-guide-sample-application-python-mysqlclient.mddevelop/dev-guide-sample-application-python-pymysql.mddevelop/dev-guide-tidb-basics.mddevelop/java-app-best-practices.mddevelop/serverless-driver-kysely-example.mddm/dm-error-handling.mddm/dm-handle-alerts.mddm/dm-webui-guide.mddr-secondary-cluster.mdfunctions-and-operators/encryption-and-compression-functions.mdglossary.mdgrafana-pd-dashboard.mdgrafana-tidb-dashboard.mdidentify-slow-queries.mdinformation-schema/information-schema-inspection-result.mdinformation-schema/information-schema-user-privileges.mdmetrics-schema.mdmigrate-from-csv-files-to-tidb.mdmigrate-from-parquet-files-to-tidb.mdmigrate-large-mysql-to-tidb.mdmysql-compatibility.mdonline-unsafe-recovery.mdoptimistic-transaction.mdpartitioned-table.mdpd-control.mdperformance-tuning-methods.mdpessimistic-transaction.mdpost-installation-check.mdquick-start-with-tidb.mdread-historical-data.mdreleases/release-5.0.0.mdreleases/release-5.1.0.mdreleases/release-5.2.0.mdreleases/release-5.4.0.mdreleases/release-6.2.0.mdreleases/release-6.4.0.mdreleases/release-6.5.0.mdreplicate-between-primary-and-secondary-clusters.mdscale-tidb-using-tiup.mdschema-cache.mdsql-statements/sql-statement-alter-user.mdsql-statements/sql-statement-create-index.mdsql-statements/sql-statement-explain-analyze.mdsql-statements/sql-statement-select.mdsql-tuning-best-practice.mdstatement-summary-tables.mdstatistics.mdsystem-variables.mdticdc/deploy-ticdc.mdticdc/ticdc-overview.mdticdc/ticdc-sink-to-mysql.mdtidb-cloud/architecture-concepts.mdtidb-cloud/backup-and-restore-concepts.mdtidb-cloud/backup-and-restore.mdtidb-cloud/changefeed-sink-to-apache-kafka.mdtidb-cloud/changefeed-sink-to-apache-pulsar.mdtidb-cloud/changefeed-sink-to-mysql.mdtidb-cloud/database-schema-concepts.mdtidb-cloud/get-started-with-cli.mdtidb-cloud/integrate-tidbcloud-with-airbyte.mdtidb-cloud/migrate-from-mysql-using-aws-dms.mdtidb-cloud/migrate-from-mysql-using-data-migration.mdtidb-cloud/migrate-from-op-tidb.mdtidb-cloud/monitor-built-in-alerting.mdtidb-cloud/notifications.mdtidb-cloud/premium/migrate-from-op-tidb-premium.mdtidb-cloud/premium/premium-export.mdtidb-cloud/releases/release-notes-2024.mdtidb-cloud/security-concepts.mdtidb-cloud/set-up-vpc-peering-connections.mdtidb-cloud/tidb-cloud-glossary.mdtidb-configuration-file.mdtidb-external-ts.mdtidb-lightning/tidb-lightning-data-source.mdtidb-lightning/tidb-lightning-distributed-import.mdtidb-lightning/tidb-lightning-physical-import-mode-usage.mdtidb-performance-tuning-config.mdtidb-resource-control-background-tasks.mdtidb-troubleshooting-map.mdtiflash/tiflash-pipeline-model.mdtiflash/troubleshoot-tiflash.mdtikv-configuration-file.mdtikv-in-memory-engine.mdtiproxy/tiproxy-grafana.mdtiproxy/tiproxy-overview.mdtiproxy/tiproxy-traffic-replay.mdtransaction-isolation-levels.mdtroubleshoot-cpu-issues.mdtroubleshoot-tidb-cluster.mdtroubleshoot-tidb-oom.mduser-account-management.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
yahonda
marked this pull request as draft
August 24, 2026 02:08
ti-chi-bot
Bot
added
the
do-not-merge/work-in-progress
yahonda
force-pushed
the
fix-style-register-consistency-2026-08-20
branch
from
August 24, 2026 02:20
056ab38 to
18ecf12
Compare
yahonda
marked this pull request as ready for review
August 24, 2026 03:01
ti-chi-bot
Bot
removed
the
do-not-merge/work-in-progress
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 10
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 1fb0656e-0ab9-4186-be5e-554c127e4191
📒 Files selected for processing (110)
ai/concepts/vector-search-overview.mdai/integrations/tidb-mcp-server.mdai/quickstart-via-python.mdalert-rules.mdas-of-timestamp.mdbackup-and-restore-using-dumpling-lightning.mdbest-practices/_index.mdbest-practices/tidb-best-practices.mdbr/backup-and-restore-overview.mdcheck-before-deployment.mdclinic/clinic-data-instruction-for-tiup.mdconfigure-load-base-split.mddashboard/dashboard-profiling.mddashboard/top-sql.mddevelop/dev-guide-connection-parameters.mddevelop/dev-guide-sample-application-golang-sql-driver.mddevelop/dev-guide-sample-application-java-jdbc.mddevelop/dev-guide-sample-application-python-django.mddevelop/dev-guide-sample-application-python-mysql-connector.mddevelop/dev-guide-sample-application-python-mysqlclient.mddevelop/dev-guide-sample-application-python-pymysql.mddevelop/dev-guide-tidb-basics.mddevelop/java-app-best-practices.mddevelop/serverless-driver-kysely-example.mddm/dm-error-handling.mddm/dm-handle-alerts.mddm/dm-webui-guide.mddr-secondary-cluster.mdfunctions-and-operators/encryption-and-compression-functions.mdglossary.mdgrafana-pd-dashboard.mdgrafana-tidb-dashboard.mdidentify-slow-queries.mdinformation-schema/information-schema-inspection-result.mdinformation-schema/information-schema-user-privileges.mdmetrics-schema.mdmigrate-from-csv-files-to-tidb.mdmigrate-from-parquet-files-to-tidb.mdmigrate-large-mysql-to-tidb.mdmysql-compatibility.mdonline-unsafe-recovery.mdoptimistic-transaction.mdpartitioned-table.mdpd-control.mdperformance-tuning-methods.mdpessimistic-transaction.mdpost-installation-check.mdquick-start-with-tidb.mdread-historical-data.mdreleases/release-5.0.0.mdreleases/release-5.1.0.mdreleases/release-5.2.0.mdreleases/release-5.4.0.mdreleases/release-6.2.0.mdreleases/release-6.4.0.mdreleases/release-6.5.0.mdreplicate-between-primary-and-secondary-clusters.mdscale-tidb-using-tiup.mdschema-cache.mdsql-statements/sql-statement-alter-user.mdsql-statements/sql-statement-create-index.mdsql-statements/sql-statement-explain-analyze.mdsql-statements/sql-statement-select.mdsql-tuning-best-practice.mdstatement-summary-tables.mdstatistics.mdsystem-variables.mdticdc/deploy-ticdc.mdticdc/ticdc-overview.mdticdc/ticdc-sink-to-mysql.mdtidb-cloud/architecture-concepts.mdtidb-cloud/backup-and-restore-concepts.mdtidb-cloud/backup-and-restore.mdtidb-cloud/changefeed-sink-to-apache-kafka.mdtidb-cloud/changefeed-sink-to-apache-pulsar.mdtidb-cloud/changefeed-sink-to-mysql.mdtidb-cloud/database-schema-concepts.mdtidb-cloud/get-started-with-cli.mdtidb-cloud/integrate-tidbcloud-with-airbyte.mdtidb-cloud/migrate-from-mysql-using-aws-dms.mdtidb-cloud/migrate-from-mysql-using-data-migration.mdtidb-cloud/migrate-from-op-tidb.mdtidb-cloud/monitor-built-in-alerting.mdtidb-cloud/notifications.mdtidb-cloud/premium/migrate-from-op-tidb-premium.mdtidb-cloud/premium/premium-export.mdtidb-cloud/releases/release-notes-2024.mdtidb-cloud/security-concepts.mdtidb-cloud/set-up-vpc-peering-connections.mdtidb-cloud/tidb-cloud-glossary.mdtidb-configuration-file.mdtidb-external-ts.mdtidb-lightning/tidb-lightning-data-source.mdtidb-lightning/tidb-lightning-distributed-import.mdtidb-lightning/tidb-lightning-physical-import-mode-usage.mdtidb-performance-tuning-config.mdtidb-resource-control-background-tasks.mdtidb-troubleshooting-map.mdtiflash/tiflash-pipeline-model.mdtiflash/troubleshoot-tiflash.mdtikv-configuration-file.mdtikv-in-memory-engine.mdtiproxy/tiproxy-grafana.mdtiproxy/tiproxy-overview.mdtiproxy/tiproxy-traffic-replay.mdtransaction-isolation-levels.mdtroubleshoot-cpu-issues.mdtroubleshoot-tidb-cluster.mdtroubleshoot-tidb-oom.mduser-account-management.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
yahonda
force-pushed
the
fix-style-register-consistency-2026-08-20
branch
from
August 25, 2026 00:19
18ecf12 to
dd0bb47
Compare
qiancai
added
translation/no-need
yahonda
force-pushed
the
fix-style-register-consistency-2026-08-20
branch
from
August 26, 2026 01:57
dd0bb47 to
c519034
Compare
Rebase PR pingcap#23584 onto the advanced i18n-ja-release-8.5 base using the content-preserving line-merge method, and re-apply katakana compound-word joins (PR pingcap#23577) that were reverted where this branch also touched the same lines. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
yahonda
force-pushed
the
fix-style-register-consistency-2026-08-20
branch
from
August 27, 2026 04:30
c519034 to
98d6744
Compare
ti-chi-bot
Bot
added
size/XXL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Corpus-wide scan for です/ます (polite) vs だ/である (plain/literary) sentence-register mixing: files that are overwhelmingly polite but have a stray plain-style sentence or paragraph, which reads jarring against the surrounding voice. Each site verified against EN and fixed to match the file's dominant polite register (9 files):
releases/release-6.5.0.md: not just a register issue - the clause was also word-order scrambled and missing ます entirely, garbling which statement types are supported. Rewritten to match EN.develop/java-app-best-practices.md,develop/dev-guide-connection-parameters.md,information-schema/information-schema-inspection-result.md,optimistic-transaction.md,grafana-pd-dashboard.md: one stray plain-ending sentence each, mismatching immediate sibling sentences/bullets.tidb-lightning/tidb-lightning-physical-import-mode-usage.md: two plain sentences in the same line fixed together.dr-secondary-cluster.md: a whole 4-sentence paragraph was plain-style, sandwiched between polite text - fixed all 4 sentences together.pessimistic-transaction.md: a 3-sentence plain paragraph plus one bullet mismatching its sibling above.This is the first batch from an ongoing scan; more candidates (bullet-list/table-cell style, which need per-list context judgment) are still being verified and may follow as additional commits on this PR.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit