i18n(ja): remove space between numbers and Japanese counters - #23578
Merged
qiancai merged 1 commit intoAug 26, 2026
Merged
Conversation
|
|
ti-chi-bot
Bot
added
area/develop
|
Important Review skippedToo many files! This PR contains 613 files, which is 463 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (613)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ti-chi-bot
Bot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
yahonda
pushed a commit
to yahonda/docs
that referenced
this pull request
Aug 20, 2026
Preemptive fix to avoid a conflict with the separate number+counter spacing sweep (PR pingcap#23578) touching the same lines. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
qiancai
added
translation/no-need
yahonda
force-pushed
the
fix-number-counter-spacing-2026-08-20
branch
from
August 25, 2026 00:20
f27428d to
38b3b4b
Compare
Rebased onto i18n-ja-release-8.5 after pingcap#23602 merged the markdownlint conformance fixes and after pingcap#23577's katakana compound-word joins. Restored 291 katakana joins (converged over 2 passes) that had been silently reverted by the initial content-preserving merge on lines this branch also touched, verified via an independent scan comparing spaced-katakana runs in the result against upstream's joined form. Also fixed 2 pre-existing MD037 violations (literal multiplication asterisks misidentified as emphasis markers) found while verifying, matching how the English source escapes them.
yahonda
force-pushed
the
fix-number-counter-spacing-2026-08-20
branch
from
August 26, 2026 02:03
38b3b4b to
dac79a0
Compare
qiancai
approved these changes
Aug 26, 2026
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Corpus-wide, a half-width numeral immediately followed by a half-width space and a Japanese counter word (e.g.
1 つ,3 秒,90 秒) is inconsistent with the majority convention of no space (e.g.1つ,3秒,90秒).Measured per-counter across the corpus, no-space is the clear majority for every common counter checked:
Excluded
個, where the two forms are nearly tied (95 space vs 94 no-space) and thus ambiguous — not fixed here.Fix is a mechanical, code-fence- and inline-code-aware substitution: skips
```fenced blocks and`inline code`spans entirely, only touching the space in plain prose. 2,103 occurrences across 625 files.Verified 0 anomalies in line-count/
**-count/[-count/]-count/backtick-count across all 625 changed files.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?