Skip to content

ticdc: update ticdc-debezium.md - #19544

Merged
ti-chi-bot[bot] merged 33 commits into
pingcap:masterfrom
wk989898:patch-4
Mar 12, 2025
Merged

ticdc: update ticdc-debezium.md#19544
ti-chi-bot[bot] merged 33 commits into
pingcap:masterfrom
wk989898:patch-4

Conversation

@wk989898

@wk989898 wk989898 commented Dec 2, 2024 •
edited by lilin90
Loading

Copy link
Copy Markdown
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

zh: pingcap/docs-cn#19704

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 2, 2024
@wk989898
wk989898 marked this pull request as draft December 2, 2024 04:29
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2024
@ti-chi-bot ti-chi-bot Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2024
@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 6, 2024
@wk989898
wk989898 marked this pull request as ready for review December 9, 2024 07:19
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2024
@lilin90 lilin90 added v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. translation/doing This PR's assignee is translating this PR. labels Jan 6, 2025
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Jan 6, 2025
@lilin90 lilin90 self-assigned this Jan 6, 2025
@lilin90

lilin90 commented Jan 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Note: Do not use hard Tabs in our documentation. Hard Tabs make the CI check fail. I've replaced each hard Tab with four spaces via the 852aa42 commit.

hfxsd
hfxsd reviewed Feb 7, 2025
View reviewed changes
Comment thread ticdc/ticdc-debezium.md Outdated
hfxsd
hfxsd reviewed Feb 7, 2025
View reviewed changes
Comment thread ticdc/ticdc-debezium.md Outdated
@lilin90 @hfxsd
Apply suggestions from code review
ab61ba3 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
lilin90
lilin90 reviewed Feb 7, 2025
View reviewed changes
Comment thread ticdc/ticdc-debezium.md Outdated
lilin90
lilin90 reviewed Feb 7, 2025
View reviewed changes
Comment thread ticdc/ticdc-debezium.md Outdated

- Debezium converts `charsetName` to `"utf8mb4"` when the column collation is `"utf8_unicode_ci"` and the character set is null, but TiCDC does not.

- Debezium escapes ENUM elements, but TiCDC does not. For example, Debezium encodes ENUM elements ('c', 'd', 'g,''h') to ('c','d','g,\'\'h').

@lilin90 lilin90 Feb 7, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the example @wk989898. It does not display well.
image

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 7, 2025
@ti-chi-bot

ti-chi-bot Bot commented Feb 7, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-02-06 03:13:18.443314318 +0000 UTC m=+327869.975726316: ☑️ agreed by lilin90.
  • 2025-02-07 05:50:54.711232319 +0000 UTC m=+423726.243644312: ☑️ agreed by hfxsd.

wk989898
wk989898 commented Feb 7, 2025
View reviewed changes
Comment thread ticdc/ticdc-debezium.md Outdated
@lilin90 @wk989898
Apply suggestions from code review
de26af5 
Co-authored-by: nhsmw <nhsmwk@gmail.com>
lilin90
lilin90 reviewed Feb 7, 2025
View reviewed changes
Comment thread ticdc/ticdc-debezium.md Outdated
wk989898
wk989898 commented Feb 7, 2025
View reviewed changes
Comment thread ticdc/ticdc-debezium.md Outdated
lilin90 and others added 2 commits February 8, 2025 10:12
@lilin90 @wk989898
Apply suggestions from code review
8954f1a 
Co-authored-by: nhsmw <nhsmwk@gmail.com>
@lilin90
Update format
fefe294
@lilin90

lilin90 commented Feb 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Content is ready to merge except the v9.0.0 version number.

wk989898
wk989898 commented Feb 28, 2025
View reviewed changes
Comment thread ticdc/ticdc-debezium.md
@lilin90 @wk989898
Add a new field
33a9091 
Co-authored-by: nhsmw <nhsmwk@gmail.com>
lilin90
lilin90 reviewed Mar 12, 2025
View reviewed changes
Comment thread ticdc/ticdc-debezium.md Outdated
@lilin90

lilin90 commented Mar 12, 2025

Copy link
Copy Markdown
Member

/unhold

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2025
@lilin90

lilin90 commented Mar 12, 2025

Copy link
Copy Markdown
Member

/approve

@ti-chi-bot

ti-chi-bot Bot commented Mar 12, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Mar 12, 2025
@ti-chi-bot
ti-chi-bot Bot merged commit 12a73d3 into pingcap:master Mar 12, 2025
This was referenced Aug 13, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes
@hongyunyan hongyunyan hongyunyan approved these changes
+1 more reviewer
@hfxsd hfxsd hfxsd approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lilin90 lilin90

Labels

approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wk989898 @lilin90 @hongyunyan @hfxsd