Reproduce generics union bound issue#953
Closed
ondrejmirtes wants to merge 1 commit intomasterfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See phpstan/phpstan#5591
/cc @arnaud-lb Looks like you're digging through some older issues, I've got one that you're more equipped to fix rather than me :) The problem here is that the type is rejected although it's exactly the same one: https://phpstan.org/r/cc421f16-0749-407d-80ac-e05e7624d3f7
The problem is that we're representing
TEntity|nullas aUnionType(new TemplateUnionType(EntityA, EntityB), null). Union inside union might not be ideal but I don't know how differently it could work.The problem is that
UnionType::accepts()does not accept the same type it's itself. Can you please look into it and figure out what's the root cause and how it could be fixed?Thank you :)