Repository navigation
Conversation
lazerg
requested review from
SakiTakamachi,
bukka and
kamil-tekiela
as code owners
October 13, 2026 12:54
LamentXU123
approved these changes
Oct 13, 2026
LamentXU123
left a comment
LamentXU123
left a comment
Member
There was a problem hiding this comment.
This looks good to me!
Please add a regression test.
Contributor
Author
|
Added a regression test in 5612eba. It uses the mysqli fake server to send a |
LamentXU123
approved these changes
Oct 13, 2026
LamentXU123
left a comment
LamentXU123
left a comment
Member
There was a problem hiding this comment.
Thanks. Will do another look before I merge but I think fine.
iliaal
pushed a commit
to iliaal/php-src
that referenced
this pull request
Oct 13, 2026
* PHP-8.4: Fix phpGH-24293: Segfault with an empty password in MariaDB PAM (php#24294)
iliaal
pushed a commit
to iliaal/php-src
that referenced
this pull request
Oct 13, 2026
* PHP-8.5: Fix phpGH-24293: Segfault with an empty password in MariaDB PAM (php#24294)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With an empty password,
mysqlnd_pam_auth_get_auth_data()returned NULL but still set the length to 1 for the trailing NUL added in bug #78680, sophp_mysqlnd_change_auth_response_write()copied a byte from a NULL pointer once the server switched tomysql_clear_password. The buffer is now always allocated, so an empty password goes out as a single NUL byte. I checked it against MariaDB 11.4 with the PAM setup from the issue; there's no test since CI has no MariaDB with PAM.Fixes GH-24293