Repository navigation
ext/fileinfo: fix use after free when streams reconstruct file info - #24181
Open
DanielEScherzer wants to merge 2 commits into
Open
DanielEScherzer wants to merge 2 commits into
DanielEScherzer wants to merge 2 commits into
Conversation
In `php_fileinfo_from_path()`, add an option to delay retrieving the `magic_set` until it is needed, after user callbacks are run, by passing in the `zval` holding the magic, rather than the magic set directly. Additionally, reload local magic variables after calling `php_fileinfo_from_path()`, since user callbacks may have run.
DanielEScherzer
force-pushed
the
fileinfo-magic-uaf
branch
from
October 7, 2026 20:33
121d06e to
9de3bb9
Compare
ndossche
reviewed
Nov 1, 2026
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
I don't care, and certainly not about a report from embargobreaker-io
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
php_fileinfo_from_path(), add an option to delay retrieving themagic_setuntil it is needed, after user callbacks are run, by passing in thezvalholding the magic, rather than the magic set directly. Additionally, reload local magic variables after callingphp_fileinfo_from_path(), since user callbacks may have run.