ext/reflection: various cleanups and simplifications (3)#22795
Merged
DanielEScherzer merged 6 commits intoJul 19, 2026
Conversation
Girgias
approved these changes
Jul 18, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Minor nit regarding the printf style format strings, otherwise LGTM.
DanielEScherzer
force-pushed
the
reflection-cleanup-202607-r3
branch
from
July 19, 2026 16:04
ed6f01f to
9930244
Compare
Girgias
approved these changes
Jul 19, 2026
Use `uint32_t` for values that are really `uint32_t`, like constant module numbers and the result from `zend_hash_num_elements()`. Use `uint32_t` for counting up, when values should never be negative. Adjust format specifiers to use `PRIu32` rather than `%d` for the uint32_t values.
Put the `*` next to the name, rather than the type
Avoid tabs or multiple spaces other than for indentation, remove a leading newline from `ReflectionProperty::hasHook()`
DanielEScherzer
force-pushed
the
reflection-cleanup-202607-r3
branch
from
July 19, 2026 16:51
9930244 to
b043ea3
Compare
Member
Author
|
Rebased on top of master, merging locally so that commits stay signed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.