Zend/zend_execute: minor refactorings (2026-04)#21609
Merged
Girgias merged 6 commits intophp:masterfrom Apr 13, 2026
Merged
Conversation
Girgias
force-pushed
the
2026-04-zend_execute-refactoring
branch
from
74ed96f to
0ec6bd2
Compare
iluuu1994
reviewed
Apr 6, 2026
Girgias
force-pushed
the
2026-04-zend_execute-refactoring
branch
from
0ec6bd2 to
2e21483
Compare
rather than ZEND_COLD zend_never_inline to align the coding style with the rest of the file
Those are never used outside of zend_execute.c so no reason to export them in a header
For consistency with other functions
…zend_never_inline For consistency with other functions
Girgias
force-pushed
the
2026-04-zend_execute-refactoring
branch
from
2e21483 to
d147fa6
Compare
Member
|
As mentioned privately, I'm unsure about the usefulness of this. Many of these functions are called by other cold functions, sometimes only once, for which outlining is not particularly useful. I also suspect compilers already avoid inlining into non-cold functions anyway, and assume the given branch is cold. Anyway, I don't object. |
Member
Author
|
I'll merge it just so that we have a consistent code style and we can revise later :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly adding const qualifiers and consistently mark error functions as
zend_never_inline.I haven't marked functions that only emit deprecations/warnings as never inline, but maybe they should?