Conversation
unlikely to be needed, but better safe than sorry
henderkes
commented
May 4, 2026
| static void frankenphp_fork_child(void) { | ||
| is_forked_child = true; | ||
| #ifdef __linux__ | ||
| prctl(PR_SET_PDEATHSIG, SIGKILL, 0, 0, 0); |
Contributor
Author
There was a problem hiding this comment.
I don't think there's an equivalent to this in macOS or BSD?
realistically speaking, it's hard to imagine this ever kicks in if a php object destructor waits on the child pid, but in case the php runtime throws an unrecoverable error in a destructor, it might exit the thread without calling the destructor responsible for signalling and cleaning up the child
henderkes
force-pushed
the
feat/fork-support
branch
from
cdb8a37 to
1f2963e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unlikely to be needed, but better safe than sorry