Allow Symfony 4#88
Merged
Merged
Conversation
fbourigault
approved these changes
Nov 10, 2017
xabbuh
approved these changes
Nov 13, 2017
dbu
approved these changes
Nov 13, 2017
dbu
left a comment
dbu
left a comment
Contributor
There was a problem hiding this comment.
i guess with the options resolver we are safe - general symfony 4 would need to be tested more. lets merge, the styleci error is not related.
|
any ETA? It blocks me from upgrading enqueue/stomp lib and others. |
Member
|
This is awesome. I will make sure this is merged during the Symfony con hack day. I will also fix all other php-http packages. |
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Allow Symfony/OptionsResolver 4.x installation.
Why?
Symfony 4 is about to be released this month (and is already in beta). There are no BC breaks in the OptionsResolver component: symfony/options-resolver@3.4...master , so I think we can safely allow its installation.