Skip to content

Issue-455: fix RabbitMqDelayPluginDelayStrategy for RabbitmMQ 3.7.5 version#456

Closed
scarbo87 wants to merge 5 commits into
php-enqueue:masterfrom
scarbo87:master
Closed

Issue-455: fix RabbitMqDelayPluginDelayStrategy for RabbitmMQ 3.7.5 version#456
scarbo87 wants to merge 5 commits into
php-enqueue:masterfrom
scarbo87:master

Conversation

@scarbo87

@scarbo87 scarbo87 commented Jun 2, 2018

Copy link
Copy Markdown

RabbitMqDelayPluginDelayStrategy: options x-delay must be header, not the property

#455

@scarbo87 scarbo87 changed the title Issue-455: fix RabbitMqDelayPluginDelayStrategy Issue-455: fix RabbitMqDelayPluginDelayStrategy for RabbitmMQ 3.7.5 version Jun 2, 2018
@makasim

makasim commented Jun 4, 2018

Copy link
Copy Markdown
Member

@scarbo87 Have you tested it? I am sure we've tested it and it worked

@scarbo87

scarbo87 commented Jun 5, 2018

Copy link
Copy Markdown
Author

@makasim, your code works for RabbitmMQ version 3.6.6, but doesn't work for version 3.7.5.
Can I make a new RabbitMq375DelayPluginDelayStrategy?

@makasim

makasim commented Jun 5, 2018

Copy link
Copy Markdown
Member

@scarbo87 Is there a link I can read more about the change?

@makasim

makasim commented Jun 8, 2018

Copy link
Copy Markdown
Member

Can I make a new RabbitMq375DelayPluginDelayStrategy?

@scarbo87 that would be great

@scarbo87

Copy link
Copy Markdown
Author

@scarbo87 that would be great

@makasim, can I update the docker rabbitmq image?

@makasim

makasim commented Jun 13, 2018

Copy link
Copy Markdown
Member

you could add another one with 3.7 version in it. and force 3.6 for current one.

@scarbo87

Copy link
Copy Markdown
Author

@makasim, added RabbitMq375DelayPluginDelayStrategy

@makasim

makasim commented Aug 15, 2018

Copy link
Copy Markdown
Member

@scarbo87 I've updated rabbitmq image to 3.7 with a delay plugin and the current implementation of delay plugin works, at least tests are passing.

see #506

closing it for now, feel free to reopen if you have some additional info or steps to reproduce the issue.

@makasim makasim closed this Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants