Skip to content

Fix functional testing documentation example#417

Closed
sbacelic wants to merge 1 commit into
php-enqueue:masterfrom
sbacelic:patch-1
Closed

Fix functional testing documentation example#417
sbacelic wants to merge 1 commit into
php-enqueue:masterfrom
sbacelic:patch-1

Conversation

@sbacelic

Copy link
Copy Markdown
Contributor

TracebleProducer is registered as ProducerInterface::class

TracebleProducer is registered as ProducerInterface::class
@makasim

makasim commented Apr 4, 2018

Copy link
Copy Markdown
Member

There must be a traceable producer service registered https://github.com/php-enqueue/enqueue-dev/blob/master/pkg/enqueue-bundle/DependencyInjection/EnqueueExtension.php#L110

If set the option true.

What are the reasons to change this?

@sbacelic

Copy link
Copy Markdown
Contributor Author

Ah, then TraceableProducer::class service needs to be made public to make it work with Symfony ^4 as:

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException : The "Enqueue\Client\TraceableProducer" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead.

Shall I submit new PR with this change?

@makasim

makasim commented Apr 10, 2018

Copy link
Copy Markdown
Member

PR is welcome

@sbacelic

Copy link
Copy Markdown
Contributor Author

Did in #422

@sbacelic sbacelic closed this Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants