fix(server): serialize dates at UTC midnight#3194
Open
LarryHu0217 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Liang Hu <lh3057@columbia.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Serializes Perspective
datevalues as UTC calendar days instead of converting local midnight withmktime(). In positive-offset time zones, the previous conversion shifted a date such as2024-01-01to the previous UTC day. Formatted date output now uses the stored calendar value directly.The regression test fixes the process timezone to
Europe/Amsterdamand verifies both the numeric UTC-midnight value and CSV output.Fixes #3106.
Validation
test_to_format.py(91 passed, 17 skipped)git diff --check origin/master...HEADTooling assistance
Codex assisted with implementation and local validation. I reviewed the resulting diff and test output.