feat(DataViewTableBasic): Make select column sticky#645
Open
johnsonm325 wants to merge 1 commit into
Open
Conversation
Contributor
|
/deploy-preview |
Author
|
Looks like it's not doing what I expect. I assume that this table is rendering as a result of my changes. If so, it looks like the furthest left row doesn't stick the way the "Repositories" column sticks, and it has the border on the right that I don't want to show. 
|
Author
|
I intended for it to look like this 
|
johnsonm325
force-pushed
the
make-select-row-sticky
branch
from
6c435f2 to
3ae0945
Compare
Author
|
/deploy-preview |
2 similar comments
Author
|
/deploy-preview |
Author
|
/deploy-preview |
johnsonm325
force-pushed
the
make-select-row-sticky
branch
from
3ae0945 to
0bf7d8d
Compare
When attempting to make the first column in a table row sticky, it doesn't make the selection column sticky and the selection column will scroll with the rest of the table. This PR makes the selection column sticky along with the "first" column.
johnsonm325
force-pushed
the
make-select-row-sticky
branch
from
0bf7d8d to
9b7ca54
Compare
johnsonm325
commented
Jun 26, 2026
Comment on lines
+7
to
+10
| export const STICKY_SELECTION_COLUMN_WIDTH = '4rem'; | ||
|
|
||
| /** Default used when computing offsets for a preceding sticky column with no explicit stickyMinWidth. */ | ||
| export const DEFAULT_STICKY_COLUMN_WIDTH = '120px'; |
Author
There was a problem hiding this comment.
This is not a good solution. I worked with Claude to determine column width at runtime, but it struggled to find a good implementation. We could rely on apps that use this table to pass widths, but that doesn't seem like the best solution. Maybe I'll take another pass at it on Monday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to make the first column in a table row sticky, it doesn't make the selection column sticky and the selection column will scroll with the rest of the table. This PR makes the selection column sticky along with the "first" column.