chore(Page) remove deprecated props by dominik-petrik · Pull Request #8185 · patternfly/patternfly-react

dominik-petrik · 2022-10-07T10:54:30Z

What: Closes #8091

patternfly-build · 2022-10-07T10:59:56Z

Preview: https://patternfly-react-pr-8185.surge.sh

A11y report: https://patternfly-react-pr-8185-a11y.surge.sh

tlabaj

LGTM

thatblindgeye

This is looking good! Had a couple of questions which @tlabaj may be able to weigh in on:

The snapshots look to have been updated where the pf-m-sticky-[top/bottom] class is removed, and a sticky attribute is instead added. Should the pf-m-sticky class not still be applied in the snapshots?
In the PageHeader component, the isManagedSidebar prop description mentions "This prop is no longer managed through PageHeader but in the Page component", and the prop is also given the alias of deprecatedIsManagedSidebar on line 46. Would we want to remove this prop as well or add a proper @deprecated in the description?

tlabaj · 2022-10-10T18:58:22Z

This is looking good! Had a couple of questions which @tlabaj may be able to weigh in on:

The snapshots look to have been updated where the pf-m-sticky-[top/bottom] class is removed, and a sticky attribute is instead added. Should the pf-m-sticky class not still be applied in the snapshots?

In the PageHeader component, the isManagedSidebar prop description mentions "This prop is no longer managed through PageHeader but in the Page component", and the prop is also given the alias of deprecatedIsManagedSidebar on line 46. Would we want to remove this prop as well or add a proper @deprecated in the description?

@thatblindgeye is correct.

It should still be pf-m-sticky-[top/bottom] for the modifier.
We should removed the isManagedSidebar prop and the associated generated console warning.

tlabaj

Please address @thatblindgeye comments

- @patternfly/react-catalog-view-extension@4.92.27 - @patternfly/react-code-editor@4.82.27 - @patternfly/react-console@4.92.27 - @patternfly/react-core@4.250.2 - @patternfly/react-docs@5.102.32 - @patternfly/react-inline-edit-extension@4.86.28 - demo-app-ts@4.202.8 - @patternfly/react-log-viewer@4.87.22 - @patternfly/react-table@4.111.5 - @patternfly/react-topology@4.88.27 - @patternfly/react-virtualized-extension@4.88.27

* chore(docs): Release notes 2022.13 * release note updates * add screnshots and versions * update note * updates from comments Co-authored-by: Titani <tlabaj@redaht.com>

- @patternfly/react-docs@5.102.33

Co-authored-by: Titani <tlabaj@redaht.com>

- @patternfly/react-docs@5.102.34

…atternfly#8160) * chore(Banner): update tests to new react testing library standards * add additional test to test screenReaderText * replace toHaveTextContent with toBeInTheDocument matcher * add test to check for pf-u-screen-reader class

- @patternfly/react-catalog-view-extension@4.92.28 - @patternfly/react-code-editor@4.82.28 - @patternfly/react-console@4.92.28 - @patternfly/react-core@4.250.3 - @patternfly/react-docs@5.102.35 - @patternfly/react-inline-edit-extension@4.86.29 - demo-app-ts@4.202.9 - @patternfly/react-log-viewer@4.87.23 - @patternfly/react-table@4.111.6 - @patternfly/react-topology@4.88.28 - @patternfly/react-virtualized-extension@4.88.28

…rnfly#8165)

- @patternfly/react-catalog-view-extension@4.92.29 - @patternfly/react-code-editor@4.82.29 - @patternfly/react-console@4.92.29 - @patternfly/react-core@4.250.4 - @patternfly/react-docs@5.102.36 - @patternfly/react-inline-edit-extension@4.86.30 - demo-app-ts@4.202.10 - @patternfly/react-log-viewer@4.87.24 - @patternfly/react-table@4.111.7 - @patternfly/react-topology@4.88.29 - @patternfly/react-virtualized-extension@4.88.29

…tternfly#8142) * fix(Dropdown next): Add support for forward ref and updated docs. * hide inner ref prop * hide innerRef Co-authored-by: Titani <tlabaj@redaht.com>

- @patternfly/react-catalog-view-extension@4.92.30 - @patternfly/react-code-editor@4.82.30 - @patternfly/react-console@4.92.30 - @patternfly/react-core@4.250.5 - @patternfly/react-docs@5.102.37 - @patternfly/react-inline-edit-extension@4.86.31 - demo-app-ts@4.202.11 - @patternfly/react-log-viewer@4.87.25 - @patternfly/react-table@4.111.8 - @patternfly/react-topology@4.88.30 - @patternfly/react-virtualized-extension@4.88.30

* chore(Title): update tests to new RTL standards * chore(Title): update tests to new RTL standards * chore(Title): update tests to new RTL standards Co-authored-by: Drew Amunategui II <drewamunateguiii@drews-mbp.acasmart.jh.edu> Co-authored-by: Drew Amunategui II <drewamunateguiii@Drews-MacBook-Pro.local>

- @patternfly/react-catalog-view-extension@4.92.31 - @patternfly/react-code-editor@4.82.31 - @patternfly/react-console@4.92.31 - @patternfly/react-core@4.250.6 - @patternfly/react-docs@5.102.38 - @patternfly/react-inline-edit-extension@4.86.32 - demo-app-ts@4.202.12 - @patternfly/react-log-viewer@4.87.26 - @patternfly/react-table@4.111.9 - @patternfly/react-topology@4.88.31 - @patternfly/react-virtualized-extension@4.88.31

…ly#8161) * docs(Empty state): Added EmptyStatePrimary to documentation * fix typo Co-authored-by: Titani <tlabaj@redaht.com>

- @patternfly/react-catalog-view-extension@4.92.32 - @patternfly/react-code-editor@4.82.32 - @patternfly/react-console@4.92.32 - @patternfly/react-core@4.250.7 - @patternfly/react-docs@5.102.39 - @patternfly/react-inline-edit-extension@4.86.33 - demo-app-ts@4.202.13 - @patternfly/react-log-viewer@4.87.27 - @patternfly/react-table@4.111.10 - @patternfly/react-topology@4.88.32 - @patternfly/react-virtualized-extension@4.88.32

dominik-petrik requested a review from tlabaj October 7, 2022 10:54

dominik-petrik marked this pull request as draft October 7, 2022 11:48

dominik-petrik marked this pull request as ready for review October 7, 2022 13:01

dominik-petrik linked an issue Oct 7, 2022 that may be closed by this pull request

[Page] - [remove deprecated props] #8091

Closed

tlabaj added Breaking change 💥 this change requires a major release and has API changes. PF5 labels Oct 7, 2022

tlabaj approved these changes Oct 7, 2022

View reviewed changes

thatblindgeye reviewed Oct 10, 2022

View reviewed changes

tlabaj requested changes Oct 10, 2022

View reviewed changes

dominik-petrik force-pushed the PageDeprecatedProps branch 2 times, most recently from 2d02681 to 33ee401 Compare October 13, 2022 10:57

dominik-petrik marked this pull request as draft October 13, 2022 11:04

thatblindgeye and others added 16 commits October 13, 2022 13:06

fix(Menu): fixed height issue with drilldown examples (patternfly#8033)

1b6f860

chore(docs): Release notes 2022.13 (patternfly#8168)

7cc3d53

* chore(docs): Release notes 2022.13 * release note updates * add screnshots and versions * update note * updates from comments Co-authored-by: Titani <tlabaj@redaht.com>

chore(release): releasing packages [ci skip]

d6b9cb6

- @patternfly/react-docs@5.102.33

chore(docs): Updated release notes (patternfly#8202)

8fb1fe6

Co-authored-by: Titani <tlabaj@redaht.com>

chore(release): releasing packages [ci skip]

7189cbd

- @patternfly/react-docs@5.102.34

chore(Sidebar): converted examples to typescript (patternfly#8062)

37c3d1b

specify est timezone for jest to run with (patternfly#8151)

ad9456d

feature(Select): flag to put create option at top of typeahead (patte…

48efe27

…rnfly#8165)

fix(Dropdown next): Add support for forward ref and updated docs. (pa…

7466616

…tternfly#8142) * fix(Dropdown next): Add support for forward ref and updated docs. * hide inner ref prop * hide innerRef Co-authored-by: Titani <tlabaj@redaht.com>

tlabaj and others added 6 commits October 13, 2022 13:06

docs(Empty state): Added EmptyStatePrimary to documentation (patternf…

c53acd3

…ly#8161) * docs(Empty state): Added EmptyStatePrimary to documentation * fix typo Co-authored-by: Titani <tlabaj@redaht.com>

chore(Page) remove deprecated props

d222cfb

update tests

25a8b8d

update docs and integration tests

8c1cf35

fix snapshots, remove isManagedSidebar prop

5860111

dominik-petrik force-pushed the PageDeprecatedProps branch from 33ee401 to 5860111 Compare October 13, 2022 11:07

dominik-petrik closed this Oct 13, 2022

dominik-petrik deleted the PageDeprecatedProps branch October 13, 2022 14:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(Page) remove deprecated props#8185

chore(Page) remove deprecated props#8185
dominik-petrik wants to merge 22 commits into
patternfly:v5from
dominik-petrik:PageDeprecatedProps

dominik-petrik commented Oct 7, 2022

Uh oh!

patternfly-build commented Oct 7, 2022 •

edited

Loading

Uh oh!

tlabaj left a comment

Uh oh!

thatblindgeye left a comment

Uh oh!

tlabaj commented Oct 10, 2022

Uh oh!

tlabaj left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

dominik-petrik commented Oct 7, 2022

Uh oh!

patternfly-build commented Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tlabaj left a comment

Choose a reason for hiding this comment

Uh oh!

thatblindgeye left a comment

Choose a reason for hiding this comment

Uh oh!

tlabaj commented Oct 10, 2022

Uh oh!

tlabaj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

patternfly-build commented Oct 7, 2022 •

edited

Loading