fix(TreeView): pass id,inert to TreeViewList - #12548
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
WalkthroughAdded ChangesTreeView rootListId/inert props
Estimated code review effort: 1 (Trivial) | ~5 minutes Sequence Diagram(s)sequenceDiagram
participant Consumer
participant TreeView
participant TreeViewList
Consumer->>TreeView: render with rootListId, inert
TreeView->>TreeViewList: id={rootListId}, inert={inert}
TreeViewList->>TreeViewList: render ul with id, inert attributes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview: https://pf-react-pr-12548.surge.sh A11y report: https://pf-react-pr-12548-a11y.surge.sh |
|
@rebeccaalpert hi - I don't see this change in PF/react-core 6.6.2... |
|
Hi @grgrzybek - Let me look into this! |
|
Thanks :) I use this version with Hawtio and I simply still see the id duplicated: <div class="pf-v6-c-tree-view pf-m-guides" id="jmx-tree-view">
<div class="pf-v6-c-toolbar" id="pf-random-id-:r2c:">
<div class="pf-v6-c-toolbar__content">
<div class="pf-v6-c-toolbar__content-section">
<div class="pf-v6-c-toolbar__group pf-m-filter-group">
<div class="pf-v6-c-toolbar__item">
<div class="pf-v6-c-tree-view__search">
<div class="pf-v6-c-form-control pf-m-icon"><input
id="input-search" name="search-input"
aria-label="Search input example" type="search">
<div class="pf-v6-c-form-control__utilities">
...
</div>
</div>
</div>
</div>
<div class="pf-v6-c-toolbar__item pf-m-expand-all">
...
</div>
</div>
</div>
</div>
<div class="pf-v6-c-toolbar__content pf-m-hidden" hidden="">
<div class="pf-v6-c-toolbar__group"></div>
</div>
</div>
<hr class="pf-v6-c-divider">
<ul class="pf-v6-c-tree-view__list" role="tree" id="jmx-tree-view"> |
What: Closes #12241
id(as newrootListIdprop onTreeView) andinert(hidden, used by animations opt in) directly to TreeViewList instead of relying on spreading generic props which was passing duplicate ids unintentionally.Summary by CodeRabbit
New Features
Tests