Skip to content

chore(Version Switcher): updated to Next Dropdown#3452

Closed
thatblindgeye wants to merge 1 commit into
patternfly:v5from
thatblindgeye:iss3450_sideNavLayout
Closed

chore(Version Switcher): updated to Next Dropdown#3452
thatblindgeye wants to merge 1 commit into
patternfly:v5from
thatblindgeye:iss3450_sideNavLayout

Conversation

@thatblindgeye

Copy link
Copy Markdown
Contributor

Draft for #3450 , should probably wait until Dropdown Next is promoted and then this can be updated again to point towards the correct package

Some updates need to be made in react-core:

  • Allow focus to go to anchors (currently if the first item is an anchor, focus is not placed in the menu)
  • Currently it does not seem like there's a way to make an anchor dropdown item open in a new tab/window

I also tested out adding visible text label above the Patternfly 3 link ("Previous versions"). That could possibly be confusing with the "Previous releases" label, and wouldn't be useful if we only plan to link to the most recent previous version (rather than PF3, PF4, etc).

@patternfly-build

Copy link
Copy Markdown
Collaborator

@thatblindgeye

Copy link
Copy Markdown
Contributor Author

Closing as #3474 resolved the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants