mcp: add furniture assessments and public agent skills - #777
Merged
Conversation
|
I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…). Please try again, rephrase, or reach out if it keeps failing. Error id: 5dbc0aac-4feb-476b-96ad-99674b4c1278 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Agents can now assess prospective furniture using exact dimensions without adding a temporary item to the scene. The collision tool returns scaled, rotated footprints, explicit clearance and units, skipped evidence, and unsupported checks; GLB export reports its unsupported status truthfully.
Adds standalone
pascal-3dandfurniture-fitskills, synthetic examples and evaluation fixtures, shared Claude/Codex Git marketplace packages, and CI package validation. Instructions preserve account and data boundaries, distinguish missing geometry from a passed check, and limit the standalone local HTTP service to one active agent client.Claude Fable 5.1 reviewed the MCP implementation and package contracts. The corrected native Codex gate passes 20/20 frozen synthetic tasks, independently adjudicated by Fable; the original 17/20 result and grader errors are preserved. Final native Claude treatment passes 3/3 tasks and 22/22 criteria. These bounded trials do not establish a general performance uplift. A separate native task passes through a clean packed CLI installation and its managed HTTP connector.
Clean local type checking and builds pass; 356 MCP tests and 20 real stdio transport cases pass. The full suite passes with the repository's pinned Bun 1.3.14; Bun 1.4 timed out an unchanged canopy stress test. Both skills install and resolve all references from the public branch in skills.sh, Claude, and fresh Linux Codex flows. Exact source hashes and limits are recorded in
skills/VALIDATION.md.How to test
bun install --frozen-lockfile.bun run check,bun scripts/validate-skills.ts, andclaude plugin validate . --strict.bun run check-types,bun run build, andbun run test --concurrency=2.bun packages/mcp/scripts/furniture-fit-journey.ts. All 20 transport cases should pass, including exact-dimension candidates, rotations, units, unsupported checks, nonmutation, and reconnect persistence.Screenshots / screen recording
Non-visual runtime, documentation, and packaging changes.
Checklist
bun devbun checkto verify)mainbranchNote
Medium Risk
Changes the MCP collision tool contract and agent-facing error semantics; impact is mitigated by broad unit tests and the furniture-fit journey harness, but downstream agents on older servers may see narrower schemas.
Overview
Ships public agent workflows (
pascal-3d,furniture-fit) with skills.sh install docs, shared Claude/Codex marketplace manifests, eval fixtures, andbun scripts/validate-skills.tswired into CI.MCP
check_collisionsis expanded into a bounded furniture-footprint assessment: optionalminimumClearance,floorOnly, and a read-onlycandidate(never mutates the scene); structured results addstatus, units, source/effective dimensions, skipped items,unsupportedChecks, overlap vs clearanceviolation, andassessmentGraphHash. Unknown levels error instead of returning an empty pass; footprint inspection rejects missing/zero/tilted geometry asinsufficient_evidence. Read-onlyREAD_ONLY_TOOL_ANNOTATIONSare applied across inspection tools;export_glbnow setsisError: truefornot_implemented.measureaddsareaUnits. A W02 stdio journey script exercises 20 frozen cases plus reconnect persistence.Docs/README describe install paths and schema-version caveats for older hosted releases.
Reviewed by Cursor Bugbot for commit a89747b. Bugbot is set up for automated code reviews on this repo. Configure here.