-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Add project plugin management and extract Nature #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import { beforeEach, describe, expect, test } from 'bun:test' | ||
| import { z } from 'zod' | ||
| import { loadPlugin, nodeRegistry } from '../registry' | ||
| import type { AnyNodeDefinition } from '../registry/types' | ||
| import type { AnyNode, AnyNodeId } from '../schema' | ||
| import useScene from './use-scene' | ||
|
|
||
| describe('scene plugin installation state', () => { | ||
| beforeEach(() => { | ||
| nodeRegistry._reset() | ||
| useScene.getState().setReadOnly(false) | ||
| useScene.getState().unloadScene() | ||
| }) | ||
|
|
||
| test('loads an explicit installed plugin list with the scene', () => { | ||
| useScene.getState().setScene({}, [], { | ||
| installedPlugins: ['pascal:trees'], | ||
| hasExplicitPluginInstallState: true, | ||
| }) | ||
|
|
||
| expect(useScene.getState().installedPlugins).toEqual(['pascal:trees']) | ||
| expect(useScene.getState().hasExplicitPluginInstallState).toBe(true) | ||
| }) | ||
|
|
||
| test('install changes are de-duplicated and become explicit', () => { | ||
| useScene.getState().setInstalledPlugins(['pascal:trees', 'pascal:trees'], { explicit: true }) | ||
|
|
||
| expect(useScene.getState().installedPlugins).toEqual(['pascal:trees']) | ||
| expect(useScene.getState().hasExplicitPluginInstallState).toBe(true) | ||
| }) | ||
|
|
||
| test('clearing geometry preserves project plugin installs', () => { | ||
| useScene.getState().setInstalledPlugins(['pascal:trees'], { explicit: true }) | ||
| useScene.getState().clearScene() | ||
|
|
||
| expect(useScene.getState().installedPlugins).toEqual(['pascal:trees']) | ||
| expect(useScene.getState().hasExplicitPluginInstallState).toBe(true) | ||
| }) | ||
|
|
||
| test('uninstall clears plugin build work and reinstall schedules it again', async () => { | ||
| const kind = 'test:plugin-node' | ||
| const definition = { | ||
| kind, | ||
| schemaVersion: 1, | ||
| schema: z.object({ id: z.string(), type: z.literal(kind) }), | ||
| category: 'utility', | ||
| defaults: () => ({}), | ||
| capabilities: {}, | ||
| } as unknown as AnyNodeDefinition | ||
| await loadPlugin({ id: 'test:plugin', apiVersion: 1, nodes: [definition] }) | ||
| const nodeId = 'plugin_node' as AnyNodeId | ||
| useScene.getState().setScene( | ||
| { | ||
| [nodeId]: { id: nodeId, type: kind } as unknown as AnyNode, | ||
| }, | ||
| [nodeId], | ||
| { installedPlugins: ['test:plugin'], hasExplicitPluginInstallState: true }, | ||
| ) | ||
|
|
||
| expect(useScene.getState().dirtyNodes.has(nodeId)).toBe(true) | ||
|
|
||
| useScene.getState().setInstalledPlugins([], { explicit: true }) | ||
| expect(useScene.getState().dirtyNodes.has(nodeId)).toBe(false) | ||
|
|
||
| useScene.getState().setInstalledPlugins(['test:plugin'], { explicit: true }) | ||
| expect(useScene.getState().dirtyNodes.has(nodeId)).toBe(true) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo skips explicit plugin flag
Medium Severity
Temporal undo/redo tracks
installedPluginsbut nothasExplicitPluginInstallState. Restoring an older plugin list after install changes can leave the explicit flag out of sync with the undone list, so default-install merging and export semantics no longer match user expectation.Reviewed by Cursor Bugbot for commit 24016ad. Configure here.