Skip to content

Fix crash when opening a non downloaded file from Details view #3696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abelgardep merged 3 commits into from
Jun 13, 2022
Merged

Fix crash when opening a non downloaded file from Details view #3696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47126e8
Fix crash when opening a non downloaded file from Details view
abelgardep Jun 13, 2022
3382b0a
Add calens item
abelgardep Jun 13, 2022
e116832
Calens changelog updated
abelgardep Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,24 @@
Changelog for ownCloud Android Client [unreleased] (UNRELEASED)
=======================================
The following sections list the changes in ownCloud Android Client unreleased relevant to
ownCloud admins and users.

[unreleased]: https://github.com/owncloud/android/compare/v2.21.0...master

Summary
-------

* Bugfix - Fix crash when opening from details screen: [#3696](https://github.com/owncloud/android/pull/3696)

Details
-------

* Bugfix - Fix crash when opening from details screen: [#3696](https://github.com/owncloud/android/pull/3696)

Fixed a crash when opening a non downloaded file from the details view.

https://github.com/owncloud/android/pull/3696

Changelog for ownCloud Android Client [2.21.0] (2022-06-07)
=======================================
The following sections list the changes in ownCloud Android Client 2.21.0 relevant to
Expand Down
5 changes: 5 additions & 0 deletions changelog/unreleased/3696
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Fix crash when opening from details screen

Fixed a crash when opening a non downloaded file from the details view.

https://github.com/owncloud/android/pull/3696
9 changes: 7 additions & 2 deletions owncloudApp/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,12 @@ public boolean onOptionsItemSelected(MenuItem item) {
return true;
}
case R.id.action_open_file_with: {
mContainerActivity.getFileOperationsHelper().openFile(getFile());
if (!getFile().isDown()) { // Download the file
Timber.d("%s : File must be downloaded before opening", getFile().getRemotePath());
((FileDisplayActivity) mContainerActivity).startDownloadForOpening(getFile());
} else {
mContainerActivity.getFileOperationsHelper().openFile(getFile());
}
return true;
}
case R.id.action_remove_file: {
Expand All @@ -305,7 +310,7 @@ public boolean onOptionsItemSelected(MenuItem item) {
}
case R.id.action_send_file: {
// Obtain the file
if (!getFile().isDown()) { // Download the file
if (!getFile().isDown()) { // Download the file
Timber.d("%s : File must be downloaded", getFile().getRemotePath());
((FileDisplayActivity) mContainerActivity).startDownloadForSending(getFile());
} else {
Expand Down