Skip to content

[FSSDK-10616] overall test improvement#279

Merged
junaed-optimizely merged 6 commits into
masterfrom
junaed/fssdk-10616-overall-test-coverage
Sep 9, 2024
Merged

[FSSDK-10616] overall test improvement#279
junaed-optimizely merged 6 commits into
masterfrom
junaed/fssdk-10616-overall-test-coverage

Conversation

@junaed-optimizely
Copy link
Copy Markdown
Collaborator

@junaed-optimizely junaed-optimizely commented Sep 5, 2024

Summary

  • Unit tests improvements of all the modules except "Client & Provider"
  • 33 new tests have been added
  • Improvements & deprecated API updates

Test plan

  • 33 new tests have been added along with improvement & deprecated API replacement

Issues

@junaed-optimizely junaed-optimizely changed the title [FSSDK-10616] experiment test improvement [FSSDK-10616] overall test improvement Sep 5, 2024
@junaed-optimizely junaed-optimizely marked this pull request as ready for review September 9, 2024 14:27
Copy link
Copy Markdown
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/utils.spec.tsx Outdated
Copy link
Copy Markdown
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the added coverage. LGTM

@junaed-optimizely junaed-optimizely merged commit 5daff74 into master Sep 9, 2024
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-10616-overall-test-coverage branch September 9, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants