Repository navigation
NO-ISSUE: Rebase 5.1 to 5.1.0-0.nightly-2026-10-21-040310 + fix vllm-gaudi rebase crash - #7583
Conversation
The RHOAI bundle no longer ships vllm-gaudi-template.yaml, causing handle_assets.py to crash with FileNotFoundError. The crash happens after clear_dir() empties the runtimes directory, leaving it incomplete — including losing kustomization.x86_64.yaml which is never regenerated by the post-processing step. Remove only the confirmed-missing vllm-gaudi entry from the rebase asset config, the runtimes kustomization, and the asset file itself. vllm-rocm is kept since its template's existence in the new bundle is unconfirmed (it was collateral damage from the crash, not a confirmed upstream removal). Fixes: https://redhat.atlassian.net/browse/USHIFT-7591 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
Pipeline controller notification This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration. Use |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe October 21 nightly versions and image digests were applied across release and optional component manifests. OpenShift dependencies and auto-rebase metadata were updated. The vLLM Gaudi runtime manifest and its asset-list entries were removed. ChangesNightly release and dependency refresh
Gaudi runtime removal
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~12 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Stable And Deterministic Test Names | |
The pull request does not change test files or Ginkgo test declarations. The changed-file patch contains no added test titles using dynamic values or legacy metadata tokens. The only test-like filenam… |
| Test Structure And Quality | |
PASS: The pull request changes no Ginkgo test files, It blocks, or test setup and wait code. The test-structure requirements are not applicable to this diff. |
| Microshift Test Compatibility | |
The pull request adds no Ginkgo e2e tests or other test files. The changed files contain configuration, manifests, dependency updates, generated/vendor code, and removal of a runtime manifest. Therefo… |
| Single Node Openshift (Sno) Test Compatibility | |
No new Ginkgo e2e tests are present in the pull-request diff. No changed test files or added Describe, Context, When, It, or similar declarations were found. The changes are manifests, depende… |
| Topology-Aware Scheduling Compatibility | |
PASS — The pull request does not introduce topology-sensitive scheduling constraints. Its manifest changes remove vllm-gaudi.yaml and its kustomization entries; the deleted runtime had no affinity, … |
| Ote Binary Stdout Contract | |
The pull request changes no OTE binary or test-suite setup code. Changed Go files are vendor API/client-generated files only; no added or removed fmt.Print*, klog, log, os.Stdout, RunSpecs, … |
| Ipv6 And Disconnected Network Test Compatibility | |
PASS: The pull request adds no Ginkgo e2e tests or test files. The changed-file inventory contains manifests, dependency/vendor updates, image metadata, and rebase scripts only. No added Ginkgo declar… |
| No-Weak-Crypto | |
No weak-crypto usage is introduced by this pull request. The added source lines contain no MD5, SHA-1, DES, 3DES, RC4, Blowfish, ECB, custom crypto implementation, or non-constant-time secret comparis… |
| Container-Privileges | |
PASS. The reviewed diff adds no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation: true, or root-running security settings. The only changed runtime mani… |
| No-Sensitive-Data-In-Logs | |
PASS: The pull request introduces no logging statements or log-format changes. The changed files update manifests, image digests, dependency/vendor data, changelog entries, and rebase inputs. The only… |
| Title check | |
The title clearly identifies the main changes: rebasing to the October 21, 2026 nightly release and fixing the vllm-gaudi rebase failure. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (30 skipped: 30 unsupported.)
Full details: Stable And Deterministic Test Names
-
Explanation
The pull request does not change test files or Ginkgo test declarations. The changed-file patch contains no added test titles using dynamic values or legacy metadata tokens. The only test-like filename matches are generated API files containing “spec” in their names, not test code.
Full details: Microshift Test Compatibility
-
Explanation
The pull request adds no Ginkgo e2e tests or other test files. The changed files contain configuration, manifests, dependency updates, generated/vendor code, and removal of a runtime manifest. Therefore, the MicroShift test compatibility check is not applicable.
Full details: Single Node Openshift (Sno) Test Compatibility
-
Explanation
No new Ginkgo e2e tests are present in the pull-request diff. No changed test files or added
Describe,Context,When,It, or similar declarations were found. The changes are manifests, dependency/vendor updates, generated API code, and rebase metadata, so the SNO compatibility check is not applicable.
Full details: Topology-Aware Scheduling Compatibility
-
Explanation
PASS — The pull request does not introduce topology-sensitive scheduling constraints. Its manifest changes remove
vllm-gaudi.yamland its kustomization entries; the deleted runtime had no affinity, topology spread, replica, node selector, toleration, or PDB settings. The remaining changes update images, dependencies, generated vendor API files, and rebase metadata. No deployment, operator, or controller scheduling behavior is added or modified.
Full details: Ote Binary Stdout Contract
-
Explanation
The pull request changes no OTE binary or test-suite setup code. Changed Go files are vendor API/client-generated files only; no added or removed
fmt.Print*,klog,log,os.Stdout,RunSpecs,BeforeSuite,AfterSuite,TestMain, orSynchronizedBeforeSuiteusage appears in the diff. The changed runtime and image metadata cannot violate the stdout contract.
Full details: Ipv6 And Disconnected Network Test Compatibility
-
Explanation
PASS: The pull request adds no Ginkgo e2e tests or test files. The changed-file inventory contains manifests, dependency/vendor updates, image metadata, and rebase scripts only. No added Ginkgo declarations or test-specific IPv4/external-connectivity behavior appears in the diff. URLs and
127.0.0.1text found in added vendored documentation are not test code.
Full details: No-Weak-Crypto
-
Explanation
No weak-crypto usage is introduced by this pull request. The added source lines contain no MD5, SHA-1, DES, 3DES, RC4, Blowfish, ECB, custom crypto implementation, or non-constant-time secret comparison. The CBOM already contained weak-crypto entries in the base; the pull request changes only generated identifiers and metadata, with the same occurrences in both revisions.
Full details: Container-Privileges
-
Explanation
PASS. The reviewed diff adds no
privileged: true,hostPID,hostNetwork,hostIPC,SYS_ADMIN,allowPrivilegeEscalation: true, or root-running security settings. The only changed runtime manifest removesvllm-gaudi.yaml; the remaining manifest changes update image digests and release metadata only.
Full details: No-Sensitive-Data-In-Logs
-
Explanation
PASS: The pull request introduces no logging statements or log-format changes. The changed files update manifests, image digests, dependency/vendor data, changelog entries, and rebase inputs. The only runtime-related change removes the vllm-gaudi manifest and its kustomization entry. A full added-line scan found no logging APIs and no added credentials, tokens, PII, session IDs, or customer data in log calls.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
Comment @coderabbitai help to get the list of available commands.
|
/pipeline auto |
|
Pipeline controller notification The |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eslutsky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
eslutsky
changed the title
eslutsky
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Scheduling tests matching the |
|
@eslutsky: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
eslutsky
changed the title
|
/verified by CI |
openshift-ci-robot
added
the
verified
|
@eslutsky: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
eslutsky
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@eslutsky: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/close |
|
@eslutsky: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
mainto5.1.0-0.nightly-2026-10-21-040310(amd64) /5.1.0-0.nightly-arm64-2026-10-21-160957(arm64)vllm-gaudi-template.yamlRoot Cause
The previous automated rebase PR (#7577) failed CI because
handle_assets.pycrashed withFileNotFoundErrorwhile trying to copyvllm-gaudi-template.yaml— a file that no longer exists in the new RHOAI bundle. The crash happened afterclear_dir()already emptied the runtimes directory, leaving it in an incomplete state and preventingkustomization.x86_64.yamlfrom being regenerated by the post-processing step.Changes
scripts/auto-rebase/assets_ai_model_serving.yaml: removevllm-gaudientry (confirmed missing from upstream bundle);vllm-rocmis kept — its template's existence is unconfirmed since the crash occurred before reaching itassets/optional/ai-model-serving/runtimes/kustomization.yaml: removevllm-gaudi.yamlresourceassets/optional/ai-model-serving/runtimes/vllm-gaudi.yaml: deleted (no longer provided by upstream RHOAI)Fixes: https://redhat.atlassian.net/browse/USHIFT-7591
🤖 Generated with Claude Code